Python client was doing some on-success init inside call to display-repl-status #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Good call! I did some archeology on the Python client and it appears that the call to :on-success
(fn []
(display-repl-status :started
(with-repl-or-warn
(fn [repl]
... |
Contributor
|
The Python client with your changes still appears to work. I was able evaluate all of the non-async code in dev/python/sandbox.py. |
Olical
approved these changes
Jan 18, 2026
| (prep-code M.initialise-repl-code) | ||
| (fn [msgs] nil) | ||
| nil))))) | ||
| nil)))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Python stdio client's
on-success, thewith-repl-or-warncall was accidentally within thedisplay-repl-statuscall (display-repl-statusis only meant to take a single status arg). Looking at the previous generated Lua, this wasn't causing a problem as thewith-repl-or-warnblock was still getting called. These changes are more to avoid future confusion and mixups.