Skip to content

Conversation

@limesTech
Copy link

@limesTech limesTech commented Aug 15, 2025

Tip

merge #249, merge #251 and merge #245 before final testing to keep already forward changes to a minimum for this pull request

Summary of Changes

Closes #234

Visual Inspection

  • Conformance to Markdown styles: https://olog.esss.lu.se/Olog/help/CommonmarkCheatsheet
    • ...when viewing a log entry
    • ...when previewing HTML while writing a description
    • ...when viewing a log entry in the group view
  • Scroll is possible (elements don't overflow their container, and they are scrollable)
    • ...search result list
    • ...log entry group view list
    • ...log entry single view
    • ...create new log entry page
  • Overall layout fills full width and height of viewport
  • Pagination element doesn't overflow into other elements

@limesTech limesTech marked this pull request as draft August 15, 2025 18:53
@limesTech
Copy link
Author

@maxfrederiksen-ess I created a test branch bump-mui-datepicker at my fork. I think I might be able to update the whole repo if you could lend me a hand on how to migrate WizardDateInput.jsx. Will be on vacation for the next week or so, so there is no rush. Gave you the permission to directly push into this repo :)

@maxfrederiksen-ess
Copy link
Collaborator

Seems like a lot of things going on in this PR. What exactly are you trying to achieve? Would be nice to split changes into smaller PR's if possible. If you want to do a bump versions PR then do only that part 👍

@limesTech
Copy link
Author

Sry history is kind of messy. If ever merged use squashed-commit.
I synced the present main and all prerequisite merge requests but it al lot of merge conflicts and therefore created this mess ^^'.

Sadly bumping versions individually did not work with the major versions.

Did not want to merge broken versions to main.

If it is to messy i could make a new PR with cherry picked commits.

@maxfrederiksen-ess
Copy link
Collaborator

No worries, happens :)
But yeah it would be great if you could make a new PR. Maybe even break it out into multiple if it's a lot of changes. Please also perform some simple regressive tests to make sure everything works as intended 🙏

@limesTech
Copy link
Author

Sure i will cleanup and split the PR.

For the Testing:
Current main Unit Test broke in the last weeks. So i will check if it is a nessasary test for the changes und use my current setup for manual testing.

@maxfrederiksen-ess
Copy link
Collaborator

Sounds great. Currently we rely on manual tests, hopefully we will implement more automated tests in the future.

@limesTech
Copy link
Author

created a new PR #267 with squashed commit and removed e2e other separate fixes from this PR

@limesTech limesTech closed this Sep 11, 2025
@limesTech limesTech deleted the bump-all-versions branch September 11, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate deprecated modules

2 participants