This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Fixed a thing that can cause errors #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try a thing like api.getStats(Stats.hdd); api.getStats(Stats.cpu); api.getStats(Stats.elo); api.getStats(Stats.rank); api.getStats(Stats.av); api.getStats(Stats.adw); It will return an error. With this fix, the api will load the json once, then get all stats based on the loaded JSON. I added a "refresh" method too, so the dev can refresh stats and get new one.
|
Hi @c0mm4nd, your fork is 1 commit behind the main one, wich is causing conflict, can you please update your fork? |
|
thx for the updates |
|
I had to revert it since there was compilation errors: |
|
Wait lemme fix |
|
Ok, fixed. I forgot to change "return json...." to "return stats...." |
|
How didn't your IDE warn you? |
|
I wasn't on a IDE, I just changed 6 lines |
|
You actually need to create a new pull request btw |
|
k |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try a thing like
api.getStats(Stats.hdd);
api.getStats(Stats.cpu);
api.getStats(Stats.elo);
api.getStats(Stats.rank);
api.getStats(Stats.av);
api.getStats(Stats.adw);
It will return an error.
With this fix, the api will load the json once, then get all stats based on the loaded JSON.
I added a "refresh" method too, so the dev can refresh stats and get new one.