Fix create-issue crash on label-less types under bash 3.2#33
Merged
Conversation
create.sh expanded "${LABEL_FLAGS[@]}" directly. Under set -u in
bash 3.2 (the macOS system bash), expanding an empty array raises
"unbound variable", so `gh issue create` aborted for every
label-less type (i.e. Task) before the issue was created.
Use the portable ${LABEL_FLAGS[@]+"${LABEL_FLAGS[@]}"} guard, which
expands to nothing when the array is empty and preserves per-element
quoting when it is not. No behavior change on bash 4.4+.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
lubomirw
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
create.shin thecreate-issueskill expanded"${LABEL_FLAGS[@]}"unconditionally. Underset -uin bash 3.2 (the macOS system bash), expanding an empty array raisesunbound variable, sogh issue createaborted before the issue was created — for every label-less type, which today means every Task.Switched to the portable guard
${LABEL_FLAGS[@]+"${LABEL_FLAGS[@]}"}.Why it's safe / multiplatform
set -ucase was already fixed upstream, so this is a no-op there — no regression.wordpart is"${LABEL_FLAGS[@]}", so each element is still expanded individually and correctly quoted — multi-word labels are preserved.Verified on bash 3.2: the original form fails with
a[@]: unbound variable; the guarded form succeeds for both empty and non-empty arrays with quoting intact.How surfaced
Hit while creating a Task via
/create-issue(OmniTrustILM/core#1645) — Task carries no default labels, so it triggered the empty-array path every time.🤖 Generated with Claude Code