Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Certain React rendering sequences can apparently cause the singly-linked WeakRef list added in #154 to reference in circles. This causes the
whileloop cleaning up weak refs to run infinitely. This can only happen inuseAtomSelector'sprevCachelinked list, notuseAtomSelector's oruseAtomInstance'sprevEdgelinked lists.Mark each node as materialized when it's visited to kick out of the while loop when it hits a node it's already seen. Verify this fixes the problem for
useAtomSelector'sprevCachelinked list. Do the same for theprevEdgelinked lists inuseAtomSelectoranduseAtomInstancejust in case something we change later possibly introduces the same problem for those.I will add repro tests in a separate PR
Issues
Resolves #160