feat(atoms): improve proxies, esp sets with mutate shorthand#331
Open
feat(atoms): improve proxies, esp sets with mutate shorthand#331
Conversation
13839aa to
6f7ac8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a signal contains a JS Set, normal mutation operations work on it, e.g.:
But
.mutate's shorthand forms are unable to perform these operations:It isn't straightforward that this isn't supported. We can support this. So now we do.
While I was in there, I also added these changes:
Prevent adding transactions for every unchanged value passed to the
.mutateshorthands. This highly optimizes spread operations - e.g.Prevent recursing deeper when object refs match
Adjust types to accept an array pluck shorthand:
This worked previously, but the types didn't reflect it. Now they do.