fix(atoms): clean up MappedSignal#C when no inner signal changes state#345
Merged
fix(atoms): clean up MappedSignal#C when no inner signal changes state#345
MappedSignal#C when no inner signal changes state#345Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I had Claude run through the events system to try to find any bugs. It didn't on the first pass, which is great, but I pressed it and it did find an edge case on the second try. Claude's summary:
It looks like a real edge case to me and not even that difficult to repro. So I'm PR'ing the fix. Claude added 38 tests before finding this, so I've committed those too.