-
Notifications
You must be signed in to change notification settings - Fork 336
Fix issue #1395 #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #1395 #1413
Conversation
@amrhossamdev can you review the chages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good & well done. Please make your changes specific and do only the minimum code changes needed. Thank you!
Could you please insert a photo of the Google Accessibility app after it has been edited? @Shiwal25 |
@amrhossamdev I've already included this screenshot in the commit, but I'm reattaching it here for convenience. |
Thank you for your contribution. I don't think it's important because it affects the app's view. I believe the current state is good, so I will close it for now. Maybe we can adjust it next time. |
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xml
style template to your code in Android Studio.Run the unit tests with
gradlew connectedObaGoogleDebugAndroidTest
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)
fix #1395
