Skip to content

Fix issue #1395 #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix issue #1395 #1413

wants to merge 2 commits into from

Conversation

Shiwal25
Copy link

@Shiwal25 Shiwal25 commented Apr 6, 2025

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

fix #1395
WhatsApp Image 2025-04-06 at 10 27 15_51733f4c

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2025

CLA assistant check
All committers have signed the CLA.

@Shiwal25
Copy link
Author

Shiwal25 commented Apr 6, 2025

@amrhossamdev can you review the chages.

@Shiwal25 Shiwal25 changed the title fix Bus Options Touch Target Size Too Small #1395 Fix issue #1395 Apr 6, 2025
Copy link
Member

@amrhossamdev amrhossamdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & well done. Please make your changes specific and do only the minimum code changes needed. Thank you!

@Shiwal25 Shiwal25 requested a review from amrhossamdev April 8, 2025 14:58
@amrhossamdev
Copy link
Member

amrhossamdev commented Apr 8, 2025

Could you please insert a photo of the Google Accessibility app after it has been edited? @Shiwal25

@Shiwal25
Copy link
Author

Shiwal25 commented Apr 9, 2025

@amrhossamdev I've already included this screenshot in the commit, but I'm reattaching it here for convenience.
WhatsApp Image 2025-04-09 at 09 00 19_39a8c2fb

@amrhossamdev
Copy link
Member

Thank you for your contribution. I don't think it's important because it affects the app's view. I believe the current state is good, so I will close it for now. Maybe we can adjust it next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bus Options Touch Target Size Too Small
3 participants