Fix: Makes service alert scrollable and fix text color #1456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm new to open-source contributions and I've been working on a fix for this issue.
This pull request fixes #1454 by:
SituationDialogFragment.javato set a max height on theScrollView. This makes the dialog scrollable when the alert text is very long.SituationDialogFragment.javato manually check for dark/light mode. This sets the text color toBLACK(in light mode) orWHITE(in dark mode) so it's always readable.situation.xmlto use a theme-aware background (?android:attr/colorBackground) so it also respects light/dark mode.I tested this on my device by creating a fake alert, and it seems to solve the issue. I hope this helps!
AndroidStyle.xmlstyle template to your code in Android Studio.gradlew connectedObaGoogleDebugAndroidTestto make sure you didn't break anythingNote: I am not using Android Studio, so I was unable to apply the
AndroidStyle.xmltemplate. I ran the connected tests successfully and manually tested the fix by building the APK and installing it on my phone.