Skip to content

fix: resolve nullPointerException issue #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve nullPointerException issue #1458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion onebusaway-android/src/main/java/org/onebusaway/android/util/UIUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,26 @@ public static void sendEmail(Context context, String email, String location,
UIUtils.sendEmail(context, email, location, obaRegionName, regionSelectionMethod,
tripPlanUrl, tripPlanFail);
}
/**
* Safely formats a string resource using the provided format arguments.
*
* This method replaces any null elements in the varargs array with an empty string
* before calling {@link Context#getString(int, Object...)} to avoid formatting errors
* or unexpected "null" text in the resulting string.
*
* @param context the Context used to retrieve the string resource
* @param resId the resource id of the string to format
* @param formatArgs optional format arguments to be interpolated into the resource;
* any null elements will be converted to empty strings
* @return the formatted string from resources with null format arguments replaced by empty strings
*/
private static String safeGetString(Context context, int resId, Object... formatArgs) {
Object[] safeArgs = new Object[formatArgs.length];
for (int i = 0; i < formatArgs.length; i++) {
safeArgs[i] = (formatArgs[i] != null) ? formatArgs[i] : "";
}
return context.getString(resId, safeArgs);
}

/**
* Opens email apps based on the given email address
Expand Down Expand Up @@ -725,7 +745,7 @@ private static void sendEmail(Context context, String email, String location, St
// Have location
if (tripPlanUrl == null) {
// No trip plan
body = context.getString(R.string.bug_report_body,
body = safeGetString(context,R.string.bug_report_body,
obaVersion,
Build.MODEL,
Build.VERSION.RELEASE,
Expand Down