Fix: Add missing [weak self] in ServiceAlertViewController async closures#1053
Merged
aaronbrethorst merged 1 commit intoOneBusAway:mainfrom Feb 19, 2026
Conversation
aaronbrethorst
approved these changes
Feb 19, 2026
Member
aaronbrethorst
left a comment
There was a problem hiding this comment.
Nice catch, Divesh — this is a clean and correct fix for a real memory management issue. The [weak self] pattern is exactly the right approach here, and it's consistent with how async closures are handled throughout the rest of the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServiceAlertViewControllercapturesselfstrongly in two async closures, preventing deallocation if the user navigates away before the page finishes rendering.Problem
preparePage()dispatches work to a background queue anddisplayPage()dispatches back to the main queue — both captureselfstrongly. If the user opens a service alert and navigates back quickly, the view controller stays alive in memory until both closures complete.Fix
Added
[weak self]to both closures:preparePage()— background queue closuredisplayPage()— main queue closure withguard let selfbefore accessing propertiesWhy this matters
This follows the convention already used throughout the codebase where async closures always use
[weak self].