Fix bookmarks tab not reflecting group changes on tab switch#1055
Merged
aaronbrethorst merged 1 commit intoOneBusAway:mainfrom Feb 22, 2026
Merged
Conversation
aaronbrethorst
approved these changes
Feb 22, 2026
Member
aaronbrethorst
left a comment
There was a problem hiding this comment.
Hey Divesh — sharp diagnosis on this one. The root cause analysis is spot on: group changes weren't being persisted until viewWillDisappear, so the Bookmarks tab had no way to see them on a mid-session tab switch. Calling updateModelState() before the swap and then reloadFormFromStore() after is exactly the right fix. Extracting the deferred reload into its own method also cleans up the existing moveRowAt code nicely. This looks good to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
When a user adds, deletes, or renames a bookmark group on the Groups tab and then switches to the Bookmarks tab, the changes don't appear. The bookmarks tab keeps showing the old group state until the user moves a bookmark, which happens to trigger a form reload internally.
Root Cause
toggleControllers()was missing two steps when switching from Groups → Bookmarks:userDataStore— that only happened on modal dismiss.viewDidLoadand never refreshed.Fix
updateModelState()) before switching away from the Groups tab.reloadFormFromStore()) when switching to the Bookmarks tab.reloadFormFromStore()to deduplicate the deferred reload pattern already used bymoveRowAt(see Index Out of Bounds When Reordering Bookmarks in ManageBookmarksViewController #922).Files Changed
ManageBookmarksAndGroupsViewController.swiftManageBookmarksViewController.swiftreloadFormFromStore(), deduplicatemoveRowAtBefore (Bug) | After (Fixed)
issue.mov
fix.mov