Skip to content

fix: update activeClasses for TabItem components in SearchPane #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

iqbalcodes6602
Copy link
Contributor

added an activeClass to both the tabs to override the existing primary color to brand

fixes: #190

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine, but the linter is failing. Also, please squash all three resulting commits into a single one.

@coveralls
Copy link

coveralls commented Mar 6, 2025

Coverage Status

coverage: 15.725% (-0.01%) from 15.737%
when pulling dd7ebdd on iqbalcodes6602:Search-Pane-tabs-should-use-branding-colors
into c45f8fc on OneBusAway:main.

fix: update activeClasses for TabItem components in SearchPane

fix: improve formatting of TabItem components in SearchPane
@iqbalcodes6602 iqbalcodes6602 force-pushed the Search-Pane-tabs-should-use-branding-colors branch from 059224d to dd7ebdd Compare March 6, 2025 15:14
@iqbalcodes6602
Copy link
Contributor Author

The changes look fine, but the linter is failing. Also, please squash all three resulting commits into a single one.

hi @aaronbrethorst done as said.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the desired behavior here. The active tab here should be green not orange:
image

@iqbalcodes6602
Copy link
Contributor Author

I'm not seeing the desired behavior here. The active tab here should be green not orange: image

hi @aaronbrethorst ,
in my local env it shows green only
image
i dont know whats the reason behind this inconsistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Pane tabs should use branding colors
3 participants