feat: add option to hide region name in navigation bar #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SHOW_REGION_NAME_IN_NAV_BAR build-time configuration to control whether the region name text is displayed in the navigation bar. This helps conserve horizontal space on mobile devices. - Defaults to true for backwards compatibility - Logo alt text still uses region name for accessibility - Uses Vite's define feature to expose non-prefixed env var Fixes #291
aaronbrethorst
force-pushed
the
fix-291
branch
from
2a742cd to
de3e741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SHOW_REGION_NAME_IN_NAV_BARbuild-time configuration to control region name visibility in navigation bartruefor backwards compatibilityaltattribute still uses region name for accessibility when text is hiddenTest plan
SHOW_REGION_NAME_IN_NAV_BAR=falseand confirm region name text is hiddenCloses #291