Juhitha fix financials endpoints validation

[Juhitha-Reddy]

Description

Fix backend errors and finalize Financials endpoints for Phase 2 Summary Dashboard. Correct the materials cost calculation and add defensive validation so the UI KPIs can reliably consume:

• Total Project Cost
• Material Cost
• Labor Cost
• Equipment Cost

Fixes: High bug where Financials endpoints could return 500 for valid requests (incorrect helper usage, missing ObjectId validation).
Implements: Backend support for Phase 2 Financials KPIs (WBS), aligned to frontend integration.

Related PRS (if any):

• This backend PR pairs with the frontend PR that adds Financials KPI tiles.
• Prior related work: Sanjeevkumar - Added APIs for financial summary of the Building Projects #1307, Meenashi - Takeover: Sanjeev30 sanjeev phase 2 financial summary data apis #1595.
• Latest frontent PR to be tested with : Juhitha - Add Financials KPI tiles with isolated CSS and gated rendering HighestGoodNetworkApp#4152

Main changes explained:

• Update src/controllers/bmdashboard/bmFinancialController.js
  • Correct calls to calculateMaterialsCost to pass only projectId (previously passed model + id).
  • Add ObjectId validation and clearer errors for:
    • GET /api/financials/project/:projectId/total-cost
    • GET /api/financials/project/:projectId/costs
  • Keep existing response shapes:
    • total-cost → { totalCost }
    • costs → { materialsCost, laborCost, equipmentCost }
    • mom-changes unchanged → { materialCostChange, laborCostChange, equipmentCostChange }
• No unrelated code or formatting changes.

How to test:

1. Check into this backend branch.

2. Environment setup:

   • Use Node 18+ (or 20) and recent npm.
   • Install dependencies:

     npm install

   • If your local start crashes on optional LB/SMS modules, either install missing deps or disable those features locally:

     npm run build
     npm run start
     

3. run the frontend application.

4. Navigate to /bmdashboard/totalconstructionsummary → expand “Financials” and verify:

5. Navigate to /bmdashboard/totalconstructionsummary → expand “Financials” and verify:

   • Project dropdown appears as soon as project IDs load.
   • After financial APIs resolve, four KPI tiles render with values:
     • Total Project Cost (from total-cost)
     • Material/Labor/Equipment (from costs)
     • Optional “MoM: …%” on Equipment when available (from mom-changes).
   • ExpenseBarChart remains visible.
   • Selecting a different project updates KPI values.

6. Verify the new feature works in dark mode.

Screenshots or videos of changes:

Screen.Recording.2025-10-01.at.9.55.12.PM.mov

[vivekchandrabs]

I checkout to the backend branch and also to the proper frontend branch, but when I ran the application the project card was not rendering.

[Anusha-Gali]

Hi Juhitha,

I have reviewed your PR locally and the backend works as per requirement.

[one-community]

Thank you all, merging!