Chirag: Update pagination to be applicable only when specified#2176
Open
ChiragBellara wants to merge 9 commits into
Open
Chirag: Update pagination to be applicable only when specified#2176ChiragBellara wants to merge 9 commits into
ChiragBellara wants to merge 9 commits into
Conversation
ChiragBellara
changed the title
ChiragBellara
changed the title
one-community
added
the
High Priority - Please Review First
kunchalasireesha
requested changes
May 2, 2026
kunchalasireesha
left a comment
kunchalasireesha
left a comment
There was a problem hiding this comment.
Nice work refactoring the helper functions out of the main controller! It's much cleaner now.
I've left a few comments regarding:
Bug Fix: Passing the userId through so waitlist positions show up.
Cleanup: Simplifying the query builder logic.
Once these are addressed, this looks good to go!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PRS (if any):
This backend PR is related to OneCommunityGlobal/HighestGoodNetworkApp#5182 frontend PR.
Main changes explained:
How to test:
npm installandnpm run devto run this PR locallyhttp://localhost:4500/api/events-> you should see all the events at oncehttp://localhost:4500/api/events?page=1&limit=10-> you should see only the first 10 events.Screenshots or videos of changes: