Diya 🔥 fix(bs): Fixed Blue Square Deletion Issue

[DiyaWadhwani]

Description

Fixes a race condition where manually adding a blue square on Sunday overwrites the cron-assigned blue square issued at midnight. The bug occurred because addInfringements used findById + record.save() which fetched a stale snapshot of the document before the cron's $push completed, then overwrote the entire infringements array on save.

Fixes: Blue square race condition — manually added blue square deletes cron-assigned blue square on Sunday

Related PRs (if any):

N/A — backend only fix.

Main changes explained:

• Updated src/controllers/userProfileController.js addInfringements function to replace record.infringements = ...; record.save() with findByIdAndUpdate using $push so the new infringement is added atomically without overwriting any other infringements added between the findById and save calls

How to test:

1. Check out current branch
2. Run npm install and npm run dev
3. Trigger the cron job manually or simulate it by calling assignBlueSquareForTimeNotMet directly
4. Immediately after, manually add a blue square via the UI for the same user
5. Verify both blue squares are present after refresh
6. Verify only the new infringement is added, not duplicated

Note:

This is a race condition specific to Sunday when the cron runs at midnight. The cron uses $push atomically but the manual controller was doing a read-modify-write which could lose the cron's update if both operations overlapped.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud