Sayali: 🔥 change promotion-eligibility endpoint from GET to POST to resolve req.body.requestor undefined issue in production#2201
Merged
one-community merged 1 commit intoMay 8, 2026
Conversation
…e req.body.requestor undefined issue in production
|
HemanthNidamanuru
approved these changes
May 8, 2026
Member
|
Thank you all, merging! |
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
Fixes production bug where Promotion Eligibility table showed "Failed to load Reviewers" error.
The GET /api/promotion-eligibility endpoint was checking req.body.requestor for permissions, but GET requests don't reliably carry a body in production environments, causing req.body.requestor to be undefined and the permission check to fail with 403.
Fix: Changed the endpoint from GET to POST so req.body.requestor is always populated by the auth middleware.
Related PRS (if any):
Frontend PR required: update promotionActions.js to call axios.post instead of axios.get for PROMOTION_ELIGIBILITY endpoint.
…
Main changes explained:
Updated src/routes/promotionEligibilityRouter.js — changed /promotion-eligibility route from .get() to .post()
…
How to test:
Screenshots or videos of changes:
Note:
This is a backend-only fix. A corresponding frontend PR is needed to change axios.get to axios.post in promotionActions.js.