Amaan taking over for Vamsidhar - Fix Dark Mode for Supplier Performance Graph - #4442
Amaan taking over for Vamsidhar - Fix Dark Mode for Supplier Performance Graph#4442vamsidharpanithi wants to merge 12 commits into
Conversation
|
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vamsidharpanithi
added
the
High Priority - Please Review First
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Vamsidhar,
I reviewed your PR locally and as you can see below the project dropdown, dates dropdown and the tooltip are not handled in dark mode.
ShreyaMP1999
changed the title
saurabhdipte
changed the title
…erformance-dark-mode
|
There was a problem hiding this comment.
Tested the PR locally and the Supplier Performance by On-Time Delivery chart loads as expected and Dates , Project filters are good in dark and light mode. Please confirm if Proportion of tools/Equipment are in scope or not .Please check the last screenshot.
Proportion of Tools/Equipment:
The tool/project selection and date range backround are dark in light mode. Tool/Eqipment and Project are light background in dark mode. Is this scoped for this PR?
kzou55
left a comment
kzou55
left a comment
There was a problem hiding this comment.
Hi Saurabh,
I ran and tested the PR locally.
Verified that the Light and Dark Mode for the Supplier Performance by On-Time Delivery % section is fine.
-
Light Mode
-
Dark Mode
Concerns
- Not sure if this is in scope of the PR, but the Portion of Tools/Equipment section alongside the Tools by Availability have some Dark Mode issues
|
Yes, please fix this |
one-community
changed the title
AmaanSyed09
changed the title
|
Addressed the remaining issues. Merged the latest Verified the application after resolving the conflicts and confirmed that the Supplier Performance page matches the original PR implementation. Tested the dashboard to verify the layout, chart behavior, dropdown selections, totals, percentages, dark mode styling, and overall functionality. Committed the merge resolution, pushed the updated branch, and confirmed the PR is ready for review. Ready for re-review. |
|
7 participants
Description
This PR fixes the dark mode compatibility issue for the Supplier Performance Graph component in the BM Dashboard. The component was not properly switching to dark mode, causing poor visibility and contrast issues when dark mode was enabled. Additionally, this PR includes fixes for test failures and linting errors that were blocking the codebase.
Fixes # (bug list priority high/medium/low x.y.z)
Or Implements # (WBS)
Related PRS (if any):
Old Frontend PR - 3469
Backend PR - 1379
…
Main changes explained:
…
How to test:
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.