Amaan taking over for Sireesha - Peterson implemented a toast message when no user is found in Project. - #4746
Conversation
|
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…odNetworkApp into peterson-implement-toast-when-no-user-found
kzou55
left a comment
There was a problem hiding this comment.
Hi Sireesha,
I ran and tested the PR locally.
Issue/Concerns
-
Is the testing instruction correct? It says to go to the
/projectspage. I see that the red toast appears when the searched project/username is not found. But it is different from the one where I saw in the "files changed". As currently I see "Could not find user or project, please try again.". And in the file it says "No matching users found".

-
This leads me to my other confusion. I see the same red toast message that you had in the code. But it's at the
/project/members/[projectid]page when I enter a name. Correct me if I'm wrong but I just clicked on a project so I'm assuming the number means the project id. So did you mean for reviewers to test the/projectsor/project/members/[projectid]page

- If so, could you clarify why the check only checks for the first name of the user?
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Sireesha,
I tested this PR locally.
The "Search" and "Filter By" labels have a white background, and the text needs better contrast in dark mode.
When filtering values, the layout leaves empty white space below the result table.
The error toast appears correctly when a user is not found, as expected.
- Disable auto-search while typing - Trigger search only via Find button - Fix 'no users found' toast timing and prevent refresh trigger - Improve state handling for foundUsers/isValid flow - Fix dark mode contrast for Search and Filter labels - Apply UI consistency updates across Projects/Members search flow
|
|
Thank you all, merging! |
















Description
This PR was opened to implement a toast when the filter finds no users.
Related PRS (if any):
None.
Main changes explained:
The Members.jsx component has been modified to fix the bug.
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Uploading After my fix.mp4…
Note:
None.