Skip to content

Sphurthy fix vertical spacing labels - #4929

Open
sphurthy wants to merge 10 commits into
developmentfrom
sphurthy-fix-vertical-spacing-labels
Open

Sphurthy fix vertical spacing labels#4929
sphurthy wants to merge 10 commits into
developmentfrom
sphurthy-fix-vertical-spacing-labels

Conversation

@sphurthy

@sphurthy sphurthy commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Description

image

Related PRS (if any):

None

Main changes explained:

  • Reduced excess vertical spacing between filter labels and dropdowns on the All Events page for Branches, Themes, and Categories.
  • Added a scoped class in CPDashboard.jsx to target only those three filter rows.
  • Updated CPDashboard.module.css to tighten spacing by lowering label bottom margin and dropdown top margin for the scoped rows only.
  • Kept the update UI-only; no logic, API, or functional behavior was changed.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
    4.Open Community Portal and go to the All Events page.
  4. Locate the Search Filters section and check Branches, Themes, and Categories.
  5. Confirm the label-to-dropdown gap is visibly tighter and consistent with the intended compact layout.
  6. Verify other filters (for example Dates/Online) still look and behave as before.
  7. Test in both light and dark mode to ensure spacing remains consistent.

Screenshots or videos of changes:

image

@netlify

netlify Bot commented Mar 2, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit a06fa07
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a62c01295646500087a4fe8
😎 Deploy Preview https://deploy-preview-4929--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud

sonarqubecloud Bot commented Mar 2, 2026

Copy link
Copy Markdown

@Vishnu10-hub Vishnu10-hub left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sphurthy, tested locally on sphurthy-fix-vertical-spacing-labels. On Community Portal → All Events, the label-to-dropdown spacing for Branches/Themes/Categories is tighter and consistent. Dates/Online look unchanged, and spacing is consistent in both light and dark mode. Approving

Image Image

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jun 18, 2026
DeepighaJ
DeepighaJ previously approved these changes Jun 18, 2026

@DeepighaJ DeepighaJ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the filter panel UI and verified that the label-to-dropdown spacing for Branches, Themes, and Categories is visibly tighter and consistent with the intended compact layout. Alignment and spacing appear uniform across all filter sections. Approving this aspect of the change however no data available to select values in the branches/themes/categories.

Image Image Image

kzou55
kzou55 previously approved these changes Jun 18, 2026

@kzou55 kzou55 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sphurthy,

I ran and tested the PR locally. I can verify that that Search Filters section(Branches, themes, categories) and it's drop down menu is visibly tighter and consistent in both Light and Dark mode. And that the dates and online filter still behaves correctly.

Image Image

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sphurthy,

Tested this PR locally. The label-to-dropdown gap for Branches, Themes, and Categories is now tighter and consistent with the intended compact layout. Other filters like Dates/Online still look and behave as before. Verified in both light and dark mode, spacing is consistent. Everything is working fine.

Image Image

@sphurthy
sphurthy dismissed stale reviews from HemanthNidamanuru, kzou55, and DeepighaJ via 3b1047d June 23, 2026 21:25
mahathiganimi
mahathiganimi previously approved these changes Jun 26, 2026

@mahathiganimi mahathiganimi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sphurthy,

Tested these changes in my local. The filtering for themes and branches, categories won't work. However I know that this is out of PR scope. As PR totally aligns with styling and spacing of the components, which worked for me when I checked these changes. I approve this PR.

Image Image

@one-community

Copy link
Copy Markdown
Member

Thank you all, merging!

@sphurthy
sphurthy force-pushed the sphurthy-fix-vertical-spacing-labels branch from 3de3137 to 810211a Compare July 16, 2026 03:38

@kzou55 kzou55 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sphurthy,

I ran and tested the PR locally again

Testing

  • Light Mode

    Recording.2026-07-17.003603.mp4
  • Dark Mode

    Recording.2026-07-17.003539.mp4

Issues

  1. The Dates select button can a bit too much vertical spacing
Image
  1. In Dark Mode, the "All Events", "Filter" and card "Title/Name" text have poor contrast in Dark Mode
Image

Note

  • Assuming the "Apply Filters" and "Clear Filters" button are currently suppose to be not functional at the moment

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sphurthy,

The date selection button is not properly aligned and has excessive vertical spacing. Additionally, in dark mode, the “All Events,” “Filter,” and card “Title/Name” text have poor contrast, making them difficult to read.

Image Image

@DeepighaJ DeepighaJ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR locally. Below are the few suggestions
Align Radios & Checkboxes: Align the radio buttons (Tomorrow, This Weekend) and checkbox (Online Only) neatly along a straight left line.
Space between checkbox and Online only text can be improved.

Image Image

@iAbhi001

Copy link
Copy Markdown

I tried using Admin Account but could not see community portal, Should I use owner account ?

@kzou55 kzou55 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sphurthy,

I ran and tested the PR locally again.

Issues

  • Can't load events anymore

    Image

@kzou55

kzou55 commented Jul 21, 2026

Copy link
Copy Markdown

I tried using Admin Account but could not see community portal, Should I use owner account ?

@iAbhi001 You should be able to test on an Admin Account as I previously tested on Admin Account and it worked before. But currently can't load events on either Admin or Owner Account.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants