Skip to content

Mahathi taking over for Sriamsh- Implement production identity validation flow Frontend - #5420

Open
mahathiganimi wants to merge 2 commits into
developmentfrom
feature/mahathi-prod-identity-validation-frontend
Open

Mahathi taking over for Sriamsh- Implement production identity validation flow Frontend#5420
mahathiganimi wants to merge 2 commits into
developmentfrom
feature/mahathi-prod-identity-validation-frontend

Conversation

@mahathiganimi

@mahathiganimi mahathiganimi commented Jul 27, 2026

Copy link
Copy Markdown

Description

Screenshot 2026-07-27 at 6 22 34 PM https://docs.google.com/document/d/1rZDo_yYs5rUyHDkA_3HfPxdiOLaRzmQ509gr6QA2kys/edit?tab=t.0

Related PRS (if any):

This frontend PR is related to the #2289 backend PR.

Main changes explained:

Added Production Identity verification UX in Create New User:

  1. Production email/password inputs
  2. Verify action with loading/error/success states
  3. Auto-population and lock of first name/last name/email after successful verify
  4. Sends productionVerificationToken on create request
    See UserProfileAdd.jsx
  5. Added read-only behavior for identity fields on profile edit when identityLocked is true in UserProfileEdit.jsx

How to test:

  1. Check into current branch
  2. Make sure to add REACT_APP_PRODUCTION_IDENTITY_VERIFICATION_ENABLED=true to HighestGoodNetwork .env file
  3. Checkout the related backend branch and start the backend.
  4. Do npm install and restart both servers, do npm run start:local on frontend to run this PR locally
  5. Log as admin user
  6. Navigate to dashboard→ OtherLinks→ UserManagement→ CreateNewUser
    a. Verify that the Production Identity section (Production Email, Production Password, and Verify Production Identity button) is visible.
    b. Enter valid Production credentials and click Verify Production Identity. Confirm that verification succeeds, the user's first name, last name, and email are auto-populated, and those fields become read-only.
    c. Repeat the verification using a non-existent Production email. Verify that an error is displayed indicating that no matching Production account exists.
    d. Repeat the verification using a valid Production email with an incorrect password. Verify that an authentication error is displayed indicating the credentials are invalid.

@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit cfc25ff
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a6bf2e40154770008becc4f
😎 Deploy Preview https://deploy-preview-5420--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@mahathiganimi mahathiganimi changed the title Mahathi - Implement production identity validation flow Mahathi - Implement production identity validation flow Frontend Jul 27, 2026
@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jul 28, 2026
@iAbhi001
iAbhi001 self-requested a review July 29, 2026 19:20
iAbhi001
iAbhi001 previously approved these changes Jul 29, 2026

@iAbhi001 iAbhi001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local testing passed smoothly! The Production Identity section works as expected (verification, auto-population, locking fields, and handling error states for invalid/non-existent accounts).

One minor blocker before this can be merged:

  • SonarCloud Quality Gate Failure: SonarQube flagged a C Reliability Rating on the new code. Please check the SonarCloud analysis details and address the flagged bug/reliability issue so the check passes.

Once that check is green, this looks ready to go!

Image Image

AnshShah-18
AnshShah-18 previously approved these changes Jul 30, 2026

@AnshShah-18 AnshShah-18 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with the related backend PR. The Production Identity section appears correctly on the Create New User form. Valid Production credentials complete verification, auto-populate the first name, last name, and email fields, and lock those fields from editing. A non-existent Production email displays the expected account-not-found message, and a valid email with an incorrect password displays the expected authentication error. All listed frontend testing steps worked as expected.

Image Image Image

@beblicarl

Copy link
Copy Markdown
Contributor

This feature works as intended and the code is great

image image image

@beblicarl
beblicarl self-requested a review July 30, 2026 12:06
beblicarl
beblicarl previously approved these changes Jul 30, 2026
@mahathiganimi mahathiganimi changed the title Mahathi - Implement production identity validation flow Frontend Mahathi taking over for Sriamsh- Implement production identity validation flow Frontend Jul 30, 2026
@mahathiganimi
mahathiganimi dismissed stale reviews from beblicarl, AnshShah-18, and iAbhi001 via cfc25ff July 31, 2026 00:57
@sonarqubecloud

Copy link
Copy Markdown

@DeepighaJ DeepighaJ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested the PR locally.
  • Verified that the Production Identity section is displayed correctly.
  • Verification with valid Production credentials succeeds, automatically populates the user's first name, last name, and email, and makes those fields read-only as expected. Verified that using a non-existent Production email displays the appropriate "no matching Production account exists" error, and using a valid Production email with an incorrect password displays the expected authentication error for invalid credentials.
  • All tested functionality works as expected except dark mode.
  • Issue:
    Dark mode is inconsistent and needs improvement.
Image Image Image Image Image Image **Dark Mode Issue:** Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants