new provoder for Daemon type apps. by lockelost · Pull Request #25 · OneDrive/onedrive-sdk-dotnet-msa-auth-adapter

lockelost · 2016-10-20T20:51:51Z

new provoder for Daemon type apps.

cdmayer

Please address all requested changes.

cdmayer · 2016-10-25T20:29:58Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+            clientKey = applicationKey;
+
+            string authority = String.Format(CultureInfo.InvariantCulture, "https://login.microsoftonline.com/{0}", tenant);
+            authContext = new AuthenticationContext(authority);


authContext = new AuthenticationContext(authority);

Use AuthenticationContextWrapper: https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/blob/master/src/OneDrive.Sdk.Authentication.Desktop/Business/AuthenticationContextWrapper.cs

cdmayer · 2016-10-25T20:30:53Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+                    {
+                        retry = true;
+                        retryCount++;
+                        Thread.Sleep(3000);


await Task.Delay(3000);

cdmayer · 2016-10-25T20:35:25Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+        public AdalDaemonAuthenticationProvider(
+            string applicationId,
+            string applicationKey,
+            string tenant) 


string applicationId,
string applicationKey,

Please use clientId and clientSecret like the rest of the library. Change throughout this file.

cdmayer · 2016-10-25T20:36:14Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+        ClientCredential clientCredential;
+
+        // 'applicationId' : Your Application ID
+        // 'applicationKey' : Your Application Key


Please use typical class comments like this example in AuthenticationContextWrapper

/// <summary> /// Authenticates the user silently using <see cref="AuthenticationContext.AcquireTokenSilentAsync(string, string, UserIdentifier)"/>. /// </summary> /// <param name="resource">The resource to authenticate against.</param> /// <param name="clientId">The client ID of the application.</param> /// <param name="userIdentifier">The <see cref="UserIdentifier"/> of the user.</param>

cdmayer · 2016-10-25T20:37:58Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+                try
+                {
+                    // ADAL includes an in memory cache, so this call will only send a message to the server if the cached token is expired.
+                    result = await authContext.AcquireTokenAsync(serviceResourceId, clientCredential);


Again, AuthenticationContextWrapper

cdmayer · 2016-10-26T00:11:32Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+
+            var uri = new UriBuilder(request.RequestUri);
+            if (string.IsNullOrEmpty(uri.Query))
+                uri.Query = string.Format("client_secret={0}", clientKey);


Add braces around if and else statement blocks

cdmayer · 2016-10-26T00:14:12Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+                this.CurrentAccountSession.AccessToken);
+        }
+
+        protected AccountSession ConvertAuthenticationResultToAccountSession(AuthenticationResult authenticationResult)


Use the existing implementation in AdalAuthenticationProviderBase

cdmayer · 2016-10-26T00:14:41Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+
+namespace Microsoft.OneDrive.Sdk.Authentication.Business
+{
+    public class AdalDaemonAuthenticationProvider : IAuthenticationProvider


Is there a reason this doesn't extend AdalAuthenticationProviderBase?

cdmayer · 2016-10-26T00:16:04Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+                        Thread.Sleep(3000);
+                    }
+
+                    Console.WriteLine(


Shouldn't be writing to the console in the library. Remove this. If you want to log this stuff, you can log it at the client layer.

cdmayer · 2016-10-26T00:19:18Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

@@ -0,0 +1,134 @@
+using System;


Add the license

// ------------------------------------------------------------------------------ // Copyright (c) Microsoft Corporation. All Rights Reserved. Licensed under the MIT License. See License in the project root for license information. // ------------------------------------------------------------------------------

lockelost · 2016-10-26T21:04:42Z

Hi,

Sorry I was busy with my Job.
Just quick question.

I tried to apply your suggestions, but the main problem is that if I use '
AuthenticationContextWrapper' and call 'AcquireTokenSilentAsync()' to work
as a Daemon, (with no user interaction) it throws an exception it failed,
to use ''AcquireTokenAsync()' instead.

Is it because of the OneDrive SDK I installed from NugetPackage?

Best regards.,
Sunghyun wang

On Tue, Oct 25, 2016 at 8:19 PM, Chris Mayer notifications@github.com
wrote:

@cdmayer requested changes on this pull request.

Please address all requested changes.

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

   public AuthenticationContext authContext;

```
   ClientCredential clientCredential;
```

   // 'applicationId' : Your Application ID

   // 'applicationKey' : Your Application Key

   // 'tenant' : is usually a domain name for your Office365 service. Like 'yourcompany.onmicrosoft.com'

   public AdalDaemonAuthenticationProvider(

```
       string applicationId,
```
```
       string applicationKey,
```
```
       string tenant)
```
```
   {
```
```
       clientId = applicationId;
```
```
       clientKey = applicationKey;
```

       string authority = String.Format(CultureInfo.InvariantCulture, "https://login.microsoftonline.com/{0}", tenant);

       authContext = new AuthenticationContext(authority);

authContext = new AuthenticationContext(authority);

Use AuthenticationContextWrapper: https://github.com/OneDrive/
onedrive-sdk-dotnet-msa-auth-adapter/blob/master/src/
OneDrive.Sdk.Authentication.Desktop/Business/AuthenticationContextWrapper.

cs

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

```
       do
```
```
       {
```
```
           retry = false;
```
```
           try
```
```
           {
```

               // ADAL includes an in memory cache, so this call will only send a message to the server if the cached token is expired.

               result = await authContext.AcquireTokenAsync(serviceResourceId, clientCredential);

```
           }
```
```
           catch (AdalException ex)
```
```
           {
```

               if (ex.ErrorCode == "temporarily_unavailable")

```
               {
```
```
                   retry = true;
```
```
                   retryCount++;
```
```
                   Thread.Sleep(3000);
```

await Task.Delay(3000);

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

public class AdalDaemonAuthenticationProvider : IAuthenticationProvider
{

   public AccountSession CurrentAccountSession { get; internal set; }

```
   string clientId;
```
```
   string clientKey;
```

   public AuthenticationContext authContext;

```
   ClientCredential clientCredential;
```

   // 'applicationId' : Your Application ID

   // 'applicationKey' : Your Application Key

   // 'tenant' : is usually a domain name for your Office365 service. Like 'yourcompany.onmicrosoft.com'

   public AdalDaemonAuthenticationProvider(

```
       string applicationId,
```
```
       string applicationKey,
```
```
       string tenant)
```

string applicationId,
string applicationKey,

Please use clientId and clientSecret like the rest of the library. Change

throughout this file.

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

+using System.Globalization;
+using System.Threading;
+
+namespace Microsoft.OneDrive.Sdk.Authentication.Business
+{
public class AdalDaemonAuthenticationProvider : IAuthenticationProvider

{
   public AccountSession CurrentAccountSession { get; internal set; }
   string clientId;
   string clientKey;
   public AuthenticationContext authContext;
   ClientCredential clientCredential;
   // 'applicationId' : Your Application ID
   // 'applicationKey' : Your Application Key

Please use typical class comments like this example in
AuthenticationContextWrapper

    /// <summary>
    /// Authenticates the user silently using <see cref="AuthenticationContext.AcquireTokenSilentAsync(string, string, UserIdentifier)"/>.
    /// </summary>
    /// <param name="resource">The resource to authenticate against.</param>
    /// <param name="clientId">The client ID of the application.</param>
    /// <param name="userIdentifier">The <see cref="UserIdentifier"/> of the user.</param>

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

   public async Task AuthenticateUserAsync(string serviceResourceId)

```
   {
```

       AuthenticationResult result = null;

```
       result = null;
```
```
       int retryCount = 0;
```
```
       bool retry = false;
```
```
       do
```
```
       {
```
```
           retry = false;
```
```
           try
```
```
           {
```

               // ADAL includes an in memory cache, so this call will only send a message to the server if the cached token is expired.

               result = await authContext.AcquireTokenAsync(serviceResourceId, clientCredential);

Again, AuthenticationContextWrapper

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

```
           {
```

               if (ex.ErrorCode == "temporarily_unavailable")

```
               {
```
```
                   retry = true;
```
```
                   retryCount++;
```
```
                   Thread.Sleep(3000);
```
```
               }
```
```
               Console.WriteLine(
```

                   String.Format("An error occurred while acquiring a token\nTime: {0}\nError: {1}\nRetry: {2}\n",

                   DateTime.Now.ToString(),

```
                   ex.ToString(),
```
```
                   retry.ToString()));
```
```
           }
```

       } while ((retry == true) && (retryCount < 3));

retryCount < 3

Make this a constant at the top of the file instead of an embedded literal.

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

   public async Task AuthenticateRequestAsync(HttpRequestMessage request)

```
   {
```

       if (this.CurrentAccountSession == null)

```
       {
```
```
           throw new ServiceException(
```
```
               new Error
```
```
               {
```

                   Code = OAuthConstants.ErrorCodes.AuthenticationFailure,

                   Message = "Please call one of the AuthenticateUserAsync...() methods to authenticate the user before trying to authenticate a request.",

```
               });
```
```
       }
```

       if (this.CurrentAccountSession.IsExpiring)

```
       {
```
```
           throw new ServiceException(
```

Refresh the token, similar to this
https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/blob/master/src/OneDrive.Sdk.Authentication.Common/Business/AdalAuthenticationProviderBase.cs#L130

.

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

                           Message = ""

```
                       });
```
```
       }
```

       var accessTokenType = string.IsNullOrEmpty(this.CurrentAccountSession.AccessTokenType)

           ? OAuthConstants.Headers.Bearer

           : this.CurrentAccountSession.AccessTokenType;

       var uri = new UriBuilder(request.RequestUri);

       if (string.IsNullOrEmpty(uri.Query))

           uri.Query = string.Format("client_secret={0}", clientKey);

```
       else
```

           uri.Query = uri.Query.TrimStart('?') + string.Format("&client_secret={0}", clientKey);

```
       request.RequestUri = uri.Uri;
```

Extra whitespace

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

   // 'tenant' : is usually a domain name for your Office365 service. Like 'yourcompany.onmicrosoft.com'

   public AdalDaemonAuthenticationProvider(

```
       string applicationId,
```
```
       string applicationKey,
```
```
       string tenant)
```
```
   {
```
```
       clientId = applicationId;
```
```
       clientKey = applicationKey;
```

       string authority = String.Format(CultureInfo.InvariantCulture, "https://login.microsoftonline.com/{0}", tenant);

       authContext = new AuthenticationContext(authority);

       clientCredential = new ClientCredential(clientId, clientKey);

```
   }
```

Only 1 extra line

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

```
               {
```
```
                   retry = true;
```
```
                   retryCount++;
```
```
                   Thread.Sleep(3000);
```
```
               }
```
```
               Console.WriteLine(
```

                   String.Format("An error occurred while acquiring a token\nTime: {0}\nError: {1}\nRetry: {2}\n",

                   DateTime.Now.ToString(),

```
                   ex.ToString(),
```
```
                   retry.ToString()));
```
```
           }
```

       } while ((retry == true) && (retryCount < 3));

Extra whitespace

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

```
       {
```
```
           throw new ServiceException(
```
```
                       new Error
```
```
                       {
```

                           Code = OAuthConstants.ErrorCodes.AuthenticationFailure,

                           Message = ""

```
                       });
```
```
       }
```

       var accessTokenType = string.IsNullOrEmpty(this.CurrentAccountSession.AccessTokenType)

           ? OAuthConstants.Headers.Bearer

           : this.CurrentAccountSession.AccessTokenType;

       var uri = new UriBuilder(request.RequestUri);

       if (string.IsNullOrEmpty(uri.Query))

           uri.Query = string.Format("client_secret={0}", clientKey);

Add braces around if and else statement blocks

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

           : this.CurrentAccountSession.AccessTokenType;

       var uri = new UriBuilder(request.RequestUri);

       if (string.IsNullOrEmpty(uri.Query))

           uri.Query = string.Format("client_secret={0}", clientKey);

```
       else
```

           uri.Query = uri.Query.TrimStart('?') + string.Format("&client_secret={0}", clientKey);

```
       request.RequestUri = uri.Uri;
```

       request.Headers.Authorization = new AuthenticationHeaderValue(

```
           accessTokenType,
```

           this.CurrentAccountSession.AccessToken);

```
   }
```

   protected AccountSession ConvertAuthenticationResultToAccountSession(AuthenticationResult authenticationResult)

Use the existing implementation in AdalAuthenticationProviderBase

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

@@ -0,0 +1,134 @@
+using System;
+using System.Threading.Tasks;
+using Microsoft.Graph;
+using Microsoft.IdentityModel.Clients.ActiveDirectory;
+using System.Net.Http;
+using System.Net.Http.Headers;
+using System.Globalization;
+using System.Threading;
+
+namespace Microsoft.OneDrive.Sdk.Authentication.Business
+{

public class AdalDaemonAuthenticationProvider : IAuthenticationProvider

Is there a reason this doesn't extend AdalAuthenticationProviderBase?

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

```
           retry = false;
```
```
           try
```
```
           {
```

               // ADAL includes an in memory cache, so this call will only send a message to the server if the cached token is expired.

               result = await authContext.AcquireTokenAsync(serviceResourceId, clientCredential);

```
           }
```
```
           catch (AdalException ex)
```
```
           {
```

               if (ex.ErrorCode == "temporarily_unavailable")

```
               {
```
```
                   retry = true;
```
```
                   retryCount++;
```
```
                   Thread.Sleep(3000);
```
```
               }
```
```
               Console.WriteLine(
```

Shouldn't be writing to the console in the library. Remove this. If you

want to log this stuff, you can log it at the client layer.

In src/OneDrive.Sdk.Authentication.Desktop/Business/
AdalDaemonAuthenticationProvider.cs
#25 (review)
:

@@ -0,0 +1,134 @@
+using System;

Add the license

// ------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All Rights Reserved. Licensed under the MIT License. See License in the project root for license information.
// ------------------------------------------------------------------------------

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#25 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQ0OnqnlZSfkdM3MlPWYkggcDtM9d58ks5q3pybgaJpZM4Kcl2c
.

Humble S/W developer, Always.
Bruce Wang (왕성현)

cdmayer · 2016-10-26T22:07:07Z

Are you saying that calling AuthenticationContext.AcquireTokenSilentAsync works when you call it directly, but not when you call it with the context wrapper?

lockelost · 2016-10-26T22:17:09Z

Oh, I was assuming that 'AcquireTokenSilentAsync()' will do the job.
Then I think I have to add new function for Daemon app case.
Let me add following new function to IAuthenticationContextWrapper and it's
child.

Task AcquireDaemonTokenSilentAsync(string resource,
ClientCredential clientCredential);

Will send you another pull request.

Thanks.

On Wed, Oct 26, 2016 at 6:07 PM, Chris Mayer notifications@github.com
wrote:

Are you saying that calling AuthenticationContext.AcquireTokenSilentAsync
works when you call it directly, but not when you call it with the context
wrapper?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#25 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQ0Ou_JVEzZz2Z4CnaX4cPGnWkkQYTmks5q388MgaJpZM4Kcl2c
.

Humble S/W developer, Always.
Bruce Wang (왕성현)

- use clientId and clientSecret like the rest of the library - use typical class comments like this example in AuthenticationContextWrapper - Use constant, rather than hard wired value - Frefresh token, even if it never happens - remove extra white spaces - Add braces around if and else statement blocks - Use the existing implementation in AdalAuthenticationProviderBase - Modify base class to ;AdalAuthenticationProviderBase' - Remove console log

cdmayer · 2016-10-31T20:43:35Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+            _clientKey = clientSecret;
+
+            string authority = String.Format(CultureInfo.InvariantCulture, "https://login.microsoftonline.com/{0}", tenant);
+            authContextWrapper = authenticationContextWrapper;


this.authContextWrapper

cdmayer · 2016-10-31T20:43:52Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+
+            string authority = String.Format(CultureInfo.InvariantCulture, "https://login.microsoftonline.com/{0}", tenant);
+            authContextWrapper = authenticationContextWrapper;
+            clientCredential = new ClientCredential(_clientId, _clientKey);


this.clientCredential

cdmayer · 2016-10-31T20:44:11Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

+        string _clientKey;
+
+        public IAuthenticationContextWrapper authContextWrapper;
+        ClientCredential clientCredential;


add access modifier, even if it doesn't need to be explicit.

cdmayer · 2016-10-31T20:48:40Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AuthenticationContextWrapper.cs

+        /// <param name="resource">The resource to authenticate against.</param>
+        /// <param name="clientCredential">The client credential of the application.</param>
+        /// <returns>The <see cref="IAuthenticationResult"/>.</returns>
+        public async Task<IAuthenticationResult> AcquireDaemonTokenSilentAsync(string resource, ClientCredential clientCredential)


Why add this when you can use AcquireTokenSilentAsync(string resource, ClientCredential clientCredential, UserIdentifier userIdentifier) with UserIdentifier.Any? It should be the same unless I'm missing something.

That's what I asked you why AcquireTokenSilentAsync doesn't work. It throws exception.
Daemon process don't require end user ID anyway.

Are you saying AcquireTokenSilentAsync throws an exception, but AcquireTokenAsync does not? Wouldn't it pop up a dialog? I thought the reason those methods were separate was because the first did not require user interaction.

Either way, I think adding this is fine, but perhaps the name should be different (since nothing about the token is inherently limited to daemons). Can you change the method name to AcquireTokenAsync?

cdmayer · 2016-10-31T21:42:13Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AuthenticationContextWrapper.cs

+        /// <param name="resource">The resource to authenticate against.</param>
+        /// <param name="clientCredential">The client credential of the application.</param>
+        /// <returns>The <see cref="IAuthenticationResult"/>.</returns>
+        public async Task<IAuthenticationResult> AcquireDaemonTokenSilentAsync(string resource, ClientCredential clientCredential)


Are you saying AcquireTokenSilentAsync throws an exception, but AcquireTokenAsync does not? Wouldn't it pop up a dialog? I thought the reason those methods were separate was because the first did not require user interaction.

Either way, I think adding this is fine, but perhaps the name should be different (since nothing about the token is inherently limited to daemons). Can you change the method name to AcquireTokenAsync?

OneDrive#25

cdmayer · 2016-11-01T15:47:50Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AdalDaemonAuthenticationProvider.cs

-            authContextWrapper = authenticationContextWrapper;
-            clientCredential = new ClientCredential(_clientId, _clientKey);
+            this.authContextWrapper = authenticationContextWrapper;
+            this.clientCredential = new ClientCredential(_clientId, _clientKey);


this.clientCredential = new ClientCredential(this._clientId, this._clientKey);

Please look for this everywhere in the file. Instance members and methods should always have this.

cdmayer · 2016-11-01T15:49:01Z

src/OneDrive.Sdk.Authentication.Desktop/Business/AuthenticationContextWrapper.cs

        /// <param name="clientCredential">The client credential of the application.</param>
        /// <returns>The <see cref="IAuthenticationResult"/>.</returns>
-        public async Task<IAuthenticationResult> AcquireDaemonTokenSilentAsync(string resource, ClientCredential clientCredential)
+        public async Task<IAuthenticationResult> AcquireTokenSilentAsync(string resource, ClientCredential clientCredential)


Yikes sorry, this should actually be AcquireTokenAsync. It should match the call to AuthenticationContext to make it a little easier for the client to figure out what's happening under the covers. Sorry if I gave you the wrong name before :(

.

lockelost added 2 commits October 20, 2016 16:51

new provoder for Daemon type apps.

d45f189

new provoder for Daemon type apps.

Project change. Added AdalDaemonAuthenticationProvider.cs

8c8a164

cdmayer suggested changes Oct 26, 2016

View reviewed changes

lockelost added 2 commits October 27, 2016 10:59

Changed 'SilentlyAuthenticateUserAsync()'

b88d157

cdmayer suggested changes Oct 31, 2016

View reviewed changes

changed 'AcquireDaemonTokenSilentAsync' to 'AcquireTokenSilentAsync'

9a27511

OneDrive#25

cdmayer suggested changes Nov 1, 2016

View reviewed changes

lockelost added 2 commits November 1, 2016 12:44

changed AcquireDaemonTokenSilentAsync to AcquireTokenSilentAsync

3db43c1

.

typo changes

51fa3a5

.

Conversation

lockelost commented Oct 20, 2016

Uh oh!

cdmayer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lockelost commented Oct 26, 2016

Please address all requested changes.

cs

await Task.Delay(3000);

throughout this file.

Again, AuthenticationContextWrapper

Make this a constant at the top of the file instead of an embedded literal.

.

Extra whitespace

Only 1 extra line

Extra whitespace

Add braces around if and else statement blocks

Use the existing implementation in AdalAuthenticationProviderBase

Is there a reason this doesn't extend AdalAuthenticationProviderBase?

want to log this stuff, you can log it at the client layer.

Uh oh!

cdmayer commented Oct 26, 2016

Uh oh!

lockelost commented Oct 26, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants