Skip to content

Replace sidebar toggler with a new right aligned button#2586

Open
BreathingFlesh wants to merge 3 commits into
masterfrom
ogc-3054-sidebar-button
Open

Replace sidebar toggler with a new right aligned button#2586
BreathingFlesh wants to merge 3 commits into
masterfrom
ogc-3054-sidebar-button

Conversation

@BreathingFlesh

Copy link
Copy Markdown
Contributor

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Town6: Replace sidebar toggler with a new right aligned button

TYPE: Feature
LINK: OGC-3054

@linear

linear Bot commented Jul 16, 2026

Copy link
Copy Markdown

OGC-3054

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2798 1 2797 17
View the top 1 failed test(s) by shortest run time
tests/onegov/form/test_browser.py::test_formcode_keep_selection[checkbox]
Stack Traces | 3.6s run time
browser = <tests.shared.browser.ExtendedBrowser object at 0x7fb3ce11b110>
input_type = 'checkbox'

    @pytest.mark.parametrize('input_type', ('checkbox', 'radio'))
    def test_formcode_keep_selection(
        browser: ExtendedBrowser,
        input_type: str
    ) -> None:
    
        browser.visit('/formcode-select')
        browser.wait_for_js_variable('initFormcodeSelect')
        browser.execute_script(f"""
            var watcher = document.watcher = formcodeWatcherRegistry.new();
            var el = document.querySelector('#container');
            document.querySelector('textarea').value='A'
    
            initFormcodeSelect(
                el, watcher, 'textarea', '{input_type}', ['text', 'textarea']);
            watcher.update('B = ___');
        """)
    
        assert len(browser.find_by_css('.formcode-select input:checked')) == 0
        browser.execute_script("document.watcher.update('A = ___');")
    
        sleep(0.1)
    
        assert len(browser.find_by_css('.formcode-select input:checked')) == 1
        browser.execute_script("document.watcher.update('C = ___');")
    
        sleep(0.1)
    
>       assert len(browser.find_by_css('.formcode-select input:checked')) == 0
E       AssertionError: assert 1 == 0
E        +  where 1 = len(<tests.shared.browser.PlaywrightElementList object at 0x7fb3ccd1f850>)
E        +    where <tests.shared.browser.PlaywrightElementList object at 0x7fb3ccd1f850> = find_by_css('.formcode-select input:checked')
E        +      where find_by_css = <tests.shared.browser.ExtendedBrowser object at 0x7fb3ce11b110>.find_by_css

.../onegov/form/test_browser.py:192: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant