Skip to content

Feature/fix edit menu and breadcrubs#2590

Open
Tschuppi81 wants to merge 11 commits into
masterfrom
feature/fix-edit-menu-and-breadcrubs
Open

Feature/fix edit menu and breadcrubs#2590
Tschuppi81 wants to merge 11 commits into
masterfrom
feature/fix-edit-menu-and-breadcrubs

Conversation

@Tschuppi81

@Tschuppi81 Tschuppi81 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Org: Improve edit bar for several views

TYPE: Feature
LINK: None

Changed:

  • directories: switch icon
  • resources: Add menu to the far right
  • newsletters: Settings to the left, change order to: Edit, Send, Test, Copy, Delete
  • photoalbums: Edit far left
  • events: Merge config filter and settings form
  • news: Settings for root news, else keep Edit; adjust title

back / cancel using url param instead of browser history back in separate pr: #2591

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.21739% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.50%. Comparing base (4711862) to head (2dc53ba).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/onegov/org/views/settings.py 87.09% 8 Missing ⚠️
src/onegov/form/validators.py 80.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/org/forms/event.py 93.79% <ø> (-0.12%) ⬇️
src/onegov/org/forms/settings.py 73.44% <100.00%> (+0.19%) ⬆️
src/onegov/org/layout.py 89.40% <100.00%> (+0.04%) ⬆️
src/onegov/org/models/traitinfo.py 98.61% <100.00%> (+0.01%) ⬆️
src/onegov/org/views/editor.py 98.12% <100.00%> (+0.02%) ⬆️
src/onegov/org/views/occurrence.py 99.08% <100.00%> (+4.40%) ⬆️
src/onegov/town6/views/occurrence.py 91.30% <100.00%> (+5.59%) ⬆️
src/onegov/form/validators.py 88.69% <80.00%> (+0.50%) ⬆️
src/onegov/org/views/settings.py 85.18% <87.09%> (+0.49%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4711862...2dc53ba. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BreathingFlesh BreathingFlesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot more unified now. But clicking on "settings" and then "save" doesn't return to the collection in newsletter and people, it should have a return_to parameter as in the event settings.

Comment thread src/onegov/org/layout.py
),
Link(
text=_('Export All'),
url=self.request.link(self.model, name='export-all'),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a class to add an icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants