Skip to content

Pas: Unifies business logic.#2594

Open
cyrillkuettel wants to merge 3 commits into
masterfrom
ogc-3325-pas-plenarsitzung-mit-2-kommastellen-werden-komisch
Open

Pas: Unifies business logic.#2594
cyrillkuettel wants to merge 3 commits into
masterfrom
ogc-3325-pas-plenarsitzung-mit-2-kommastellen-werden-komisch

Conversation

@cyrillkuettel

@cyrillkuettel cyrillkuettel commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Pas: Unifies business logic.

TYPE: Feature
LINK: OGC-3325

Checklist

  • I have performed a self-review of my code
  • I have tested my code thoroughly by hand
  • I have added tests for my changes/features

@linear

linear Bot commented Jul 21, 2026

Copy link
Copy Markdown

OGC-3325

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.25000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.73%. Comparing base (4678f5e) to head (3d37892).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/onegov/pas/forms/attendence.py 77.27% 5 Missing ⚠️
src/onegov/pas/export_single_parliamentarian.py 76.92% 3 Missing ⚠️
src/onegov/pas/views/abschlussliste.py 84.21% 3 Missing ⚠️
src/onegov/pas/calculate_pay.py 94.28% 2 Missing ⚠️
src/onegov/pas/views/settlement_run.py 97.72% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/pas/layouts/default.py 100.00% <100.00%> (ø)
src/onegov/pas/models/attendence.py 94.23% <100.00%> (+0.11%) ⬆️
src/onegov/pas/models/change.py 93.54% <100.00%> (+0.07%) ⬆️
src/onegov/pas/utils.py 65.04% <100.00%> (+1.68%) ⬆️
...ov/pas/views/pas_excel_export_nr_3_lohnart_fibu.py 86.84% <100.00%> (+49.34%) ⬆️
src/onegov/pas/views/settlement_run.py 81.97% <97.72%> (+41.30%) ⬆️
src/onegov/pas/calculate_pay.py 88.33% <94.28%> (+7.68%) ⬆️
src/onegov/pas/export_single_parliamentarian.py 94.04% <76.92%> (-0.46%) ⬇️
src/onegov/pas/views/abschlussliste.py 94.70% <84.21%> (+29.82%) ⬆️
src/onegov/pas/forms/attendence.py 81.99% <77.27%> (+0.35%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4678f5e...3d37892. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant