Archive search

[gh-PonyM]

Adds the archive search page with tabs and pagination.
One issue I could not resolve were translations strings with variables:

• ${x} items found
• or Search in ${x}

I also added other translation strings like From date that are not ignored.
Is it reproducible?

[href]

If this is about snippets like this, you need another approach:

<strong tal:condition="archive_items" i18n:translate="">
Found ${item_count} items.
</strong>

To use variables in Chameleon templates, you need do something like this:

<strong tal:condition="archive_items" i18n:translate>
Found <tal:b i18n:name="item_count>${item_count}</tal:b> items.
</strong>

See https://chameleon.readthedocs.io/en/latest/reference.html#i18n-name

This is basically the same as providing the mapping argument in Python code.

Do you want to fix this before I do my review?

[coveralls]

Coverage increased (+0.08%) to 94.928% when pulling 4a554ee on archive_search into d87b326 on master.

[href]

Looks good to me. There are some small issues, but nothing serious. Good job!

[href]

Since domain and answer are lists (i.e. contain a plural of elements), I'd name them domains and answers.

[href]

If you don't intend to add any items to votes or elections, I would not use a list, instead use a tuple:

votes = tuple(v for v in items if v.type == 'vote')

Note that this is not the same as writing

votes = (v for v in items if v.type == 'vote')

Which would result in a generator, which is not what you want here. By using a tuple you use less memory and you communicate your intent of this list not changing later.