Updated CLAUDE.md and added hook for pull_request check if it is have real RSN/BSN#195
Open
ragaumon wants to merge 4 commits into
Open
Updated CLAUDE.md and added hook for pull_request check if it is have real RSN/BSN#195ragaumon wants to merge 4 commits into
ragaumon wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds contributor/agent guidance for working in this public ZGW APIs repo and introduces a CI gate to detect accidental inclusion of real-looking Dutch BSN/RSIN identifiers in tracked source/documentation files.
Changes:
- Expanded
CLAUDE.mdwith public-repo hygiene guidance and a “cookbook” for common development tasks. - Added a GitHub Actions workflow to run a BSN/RSIN PII scan on pushes/PRs.
- Implemented the PowerShell scanning script and added Claude Code permissions allowlist.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
CLAUDE.md |
Adds public-repo hygiene note + cookbook guidance for common engineering tasks. |
.github/workflows/ci-pii-scan.yml |
New CI workflow that runs the PII scan on pushes/PRs. |
.github/scripts/Scan-ForPii.ps1 |
New PowerShell script that scans tracked src/ and docs/ files for elfproef-valid 9-digit numbers not in the safe list. |
.claude/settings.json |
Adds an allowlist of permitted shell commands for Claude Code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add Claude Code guidance (cookbook, settings allowlist) and BSN/RSIN PII scan CI gate
Type of Change
Testing
Checklist