Skip to content

Updated CLAUDE.md and added hook for pull_request check if it is have real RSN/BSN#195

Open
ragaumon wants to merge 4 commits into
mainfrom
feature/repo-ai-improvements
Open

Updated CLAUDE.md and added hook for pull_request check if it is have real RSN/BSN#195
ragaumon wants to merge 4 commits into
mainfrom
feature/repo-ai-improvements

Conversation

@ragaumon

@ragaumon ragaumon commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Add Claude Code guidance (cookbook, settings allowlist) and BSN/RSIN PII scan CI gate

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Testing

  • Tests pass
  • Manual testing completed

Checklist

  • Self-review completed
  • Documentation updated (if needed)

Copilot AI review requested due to automatic review settings July 3, 2026 12:45
Comment thread .github/scripts/Scan-ForPii.ps1 Outdated
Comment thread .github/workflows/ci-pii-scan.yml Fixed
@ragaumon ragaumon added the Documentation Improvements or additions to documentation label Jul 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds contributor/agent guidance for working in this public ZGW APIs repo and introduces a CI gate to detect accidental inclusion of real-looking Dutch BSN/RSIN identifiers in tracked source/documentation files.

Changes:

  • Expanded CLAUDE.md with public-repo hygiene guidance and a “cookbook” for common development tasks.
  • Added a GitHub Actions workflow to run a BSN/RSIN PII scan on pushes/PRs.
  • Implemented the PowerShell scanning script and added Claude Code permissions allowlist.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
CLAUDE.md Adds public-repo hygiene note + cookbook guidance for common engineering tasks.
.github/workflows/ci-pii-scan.yml New CI workflow that runs the PII scan on pushes/PRs.
.github/scripts/Scan-ForPii.ps1 New PowerShell script that scans tracked src/ and docs/ files for elfproef-valid 9-digit numbers not in the safe list.
.claude/settings.json Adds an allowlist of permitted shell commands for Claude Code.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci-pii-scan.yml
Comment thread .github/scripts/Scan-ForPii.ps1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants