feat: earn redesign #8831
+9,914
−2,226
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| import { useCallback, useEffect, useMemo, useRef, useState } from 'react'; | ||
|
|
||
| import { View } from 'react-native'; | ||
| import WebView from 'react-native-webview'; | ||
|
|
||
| import { Stack } from '@onekeyhq/components'; | ||
|
|
||
| import { useChartConfig } from './hooks/useChartConfig'; | ||
| import { generateChartHTML } from './utils/htmlTemplate'; | ||
|
|
||
| import type { IChartMessage, ILightweightChartProps } from './types'; | ||
| import type { WebViewMessageEvent } from 'react-native-webview'; | ||
|
|
||
| export function LightweightChart({ | ||
| data, | ||
| height, | ||
| lineColor, | ||
| topColor, | ||
| bottomColor, | ||
| onHover, | ||
| }: ILightweightChartProps) { | ||
| const webViewRef = useRef<WebView>(null); | ||
| const [webViewReady, setWebViewReady] = useState(false); | ||
|
|
||
| const chartConfig = useChartConfig({ | ||
| data, | ||
| lineColor, | ||
| topColor, | ||
| bottomColor, | ||
| }); | ||
| const htmlContent = useMemo( | ||
| () => generateChartHTML(chartConfig), | ||
| [chartConfig], | ||
| ); | ||
|
|
||
| const handleMessage = useCallback( | ||
| (event: WebViewMessageEvent) => { | ||
| try { | ||
| const message = JSON.parse(event.nativeEvent.data) as IChartMessage; | ||
|
|
||
| if (message.type === 'ready') { | ||
| setWebViewReady(true); | ||
| } else if (message.type === 'hover' && onHover) { | ||
| onHover({ | ||
| time: message.time ? Number(message.time) : undefined, | ||
| price: message.price ? Number(message.price) : undefined, | ||
| x: message.x, | ||
| y: message.y, | ||
| }); | ||
| } | ||
| } catch (error) { | ||
| console.error( | ||
| 'LightweightChart: Error parsing WebView message:', | ||
| error, | ||
| ); | ||
| } | ||
| }, | ||
| [onHover], | ||
| ); | ||
|
|
||
| // Update chart when data changes | ||
| useEffect(() => { | ||
| if (webViewReady && webViewRef.current) { | ||
| const updateScript = ` | ||
| (function() { | ||
| const newConfig = ${JSON.stringify(chartConfig)}; | ||
| if (window.series) { | ||
| window.series.setData(newConfig.data); | ||
| window.chart.timeScale().fitContent(); | ||
| } | ||
| })(); | ||
| true; | ||
| `; | ||
| webViewRef.current.injectJavaScript(updateScript); | ||
| } | ||
| }, [chartConfig, webViewReady]); | ||
|
Comment on lines
+62
to
+76
Contributor
There was a problem hiding this comment. 🧩 Analysis chainCheck serialized config size and injection performance. Line 66 serializes the entire Consider:
🏁 Script executed: #!/bin/bash
# Check typical usage patterns of LightweightChart to assess data size
rg -A 5 -B 2 '<LightweightChart' --type=tsx --type=tsLength of output: 27 Length of output: 812 🏁 Script executed: #!/bin/bash
# Look for error handling patterns around injectJavaScript
rg -n 'injectJavaScript' -C 4 -g '*.ts' -g '*.tsx'Length of output: 7246 🏁 Script executed: #!/bin/bash
# Check if debounce or throttle is used anywhere in the component file
rg -n 'debounce|throttle|memo|useMemo|useCallback' packages/kit/src/components/LightweightChart/LightweightChart.native.tsxLength of output: 150 🏁 Script executed: #!/bin/bash
# Examine the full LightweightChart.native.tsx file around the useEffect
cat packages/kit/src/components/LightweightChart/LightweightChart.native.tsx | head -100Length of output: 2758 Add error handling for Line 74 lacks a try-catch wrapper. Other For JSON serialization and update frequency: the component already uses 🤖 Prompt for AI Agents |
||
|
|
||
| return ( | ||
| <Stack position="relative" height={height} width="100%"> | ||
| <View style={{ flex: 1 }}> | ||
| <WebView | ||
| ref={webViewRef} | ||
| source={{ html: htmlContent }} | ||
| onMessage={handleMessage} | ||
| scrollEnabled={false} | ||
| showsVerticalScrollIndicator={false} | ||
| showsHorizontalScrollIndicator={false} | ||
| bounces={false} | ||
| style={{ backgroundColor: 'transparent' }} | ||
| androidLayerType="hardware" | ||
| originWhitelist={['*']} | ||
| allowFileAccess={false} | ||
| allowUniversalAccessFromFileURLs={false} | ||
| mixedContentMode="never" | ||
| /> | ||
| </View> | ||
| </Stack> | ||
| ); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.