-
Notifications
You must be signed in to change notification settings - Fork 2
fix: help center new url #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update changes several URLs in the codebase. It updates help and support links in the Firmware, Header, and SearchDevice components to point to new or more general help articles. No other logic or structure is changed. Changes
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
src/components/Firmware/Firmware.tsx (1)
432-439: PreferLinkprops over manualwindow.openRelying on
window.openinside an onClick loses a11y benefits and blocks middle-click / cmd-click. Let theLinkcomponent handle navigation and mark the URL as external.- onClick={() => { - window.open( - 'https://help.onekey.so/articles/11587177-onekey-pro-%E5%BC%80%E6%9C%BA%E6%97%B6%E5%8D%A1%E5%9C%A8%E8%BF%9B%E5%BA%A6%E6%9D%A1%E7%9A%84%E4%BF%AE%E5%A4%8D%E6%96%B9%E6%B3%95' - ); - }} + href="https://help.onekey.so/articles/11587177-onekey-pro-%E5%BC%80%E6%9C%BA%E6%97%B6%E5%8D%A1%E5%9C%A8%E8%BF%9B%E5%BA%A6%E6%9D%A1%E7%9A%84%E4%BF%AE%E5%A4%8D%E6%96%B9%E6%B3%95" + target="_blank" + rel="noopener noreferrer"If
Linklacks these props, consider falling back to a plain<a>tag.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (3)
src/components/Firmware/Firmware.tsx(1 hunks)src/components/Header/Header.tsx(1 hunks)src/components/SearchDevice/index.tsx(1 hunks)
Summary by CodeRabbit