Skip to content

Conversation

@fadi-george
Copy link
Collaborator

@fadi-george fadi-george commented Dec 22, 2025

Description

One Line Summary

  • adds similar spotless check formatting like in cordova & react-native repos

Details

  • adds similar spotless build gradle settings used in other repos
  • updates pubspec yaml to include formatting check scripts (format-check and format)
  • run formatter on java and c code

Motivation

Want to have consistent formatting between the repos.

Testing

Manual testing

Can run like so:
rps format-check to check for dart or java or c formatting issues.
rps format to apply format changes.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@fadi-george fadi-george requested a review from a team as a code owner December 22, 2025 20:44
@fadi-george fadi-george merged commit 469681b into main Dec 23, 2025
2 checks passed
@fadi-george fadi-george deleted the fg/spotless branch December 23, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants