Web SDK Refactor: Add ModelStore Class#1269
Merged
Merged
Conversation
981b8cc to
0232d30
Compare
0232d30 to
56415c6
Compare
jkasten2
approved these changes
Apr 16, 2025
sherwinski
reviewed
Apr 16, 2025
| } | ||
|
|
||
| /** | ||
| * @returns list of read-only models, cloned for thread safety |
Contributor
There was a problem hiding this comment.
cloned for thread safety
nit: is this still true? I'm not sure if the ported implementation uses anything more complex than async/awaits.
| persist(): void { | ||
| if (!this.name || !this._prefs || !this.hasLoadedFromCache) return; | ||
|
|
||
| const jsonArray: unknown[] = []; |
Contributor
There was a problem hiding this comment.
nit: Is it possible to use a stronger type here? I guess it would be difficult without refactoring the return type on toJSON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of the Web SDK Refactor project. This pr is focuses on porting the follow classes/types from the Android SDK: ModelStore , OperationModelStore
Details
Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is