Skip to content

Web SDK Refactor: IdentityOperationExecutor Tests#1271

Merged
fadi-george merged 1 commit into
web-refractorfrom
fg/identity-executor-tests
Apr 16, 2025
Merged

Web SDK Refactor: IdentityOperationExecutor Tests#1271
fadi-george merged 1 commit into
web-refractorfrom
fg/identity-executor-tests

Conversation

@fadi-george

@fadi-george fadi-george commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

Description

1 Line Summary

Continuation of the Web SDK Refactor project. This pr is focuses on adding tests for the IdentityOperationExecutor tests.

Details

  • adds tests for IdentityOperationExecutor class
  • changed logic in IdentityOperationExecutor to use one try catch instead of two since theres duplicate logic thats shared between set alias and delete alias errors
  • added multiple constructor overrides since in OperationModelStore, SetAliasOperation and DeleteAliasOperation are used with no params

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable


@fadi-george fadi-george requested a review from sherwinski April 16, 2025 18:22
@fadi-george fadi-george force-pushed the fg/identity-executor-tests branch from 2bccc5e to 8dccdaa Compare April 16, 2025 18:36
@fadi-george fadi-george requested a review from jkasten2 April 16, 2025 18:37
@fadi-george fadi-george force-pushed the fg/identity-executor-tests branch from 8dccdaa to b52a9fa Compare April 16, 2025 18:40
Base automatically changed from fg/executors-1 to web-refractor April 16, 2025 20:34
@fadi-george fadi-george merged commit 2bdafc4 into web-refractor Apr 16, 2025
@fadi-george fadi-george deleted the fg/identity-executor-tests branch April 16, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants