Skip to content

Web SDK Refactor: Login Operation Executor - 2#1278

Merged
fadi-george merged 5 commits into
web-refractorfrom
fg/login-exec-3
Apr 21, 2025
Merged

Web SDK Refactor: Login Operation Executor - 2#1278
fadi-george merged 5 commits into
web-refractorfrom
fg/login-exec-3

Conversation

@fadi-george

@fadi-george fadi-george commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

Description

1 Line Summary

Continuation of the Web SDK Refactor project.

Details

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable


@fadi-george fadi-george changed the base branch from fg/login-exec-2 to web-refractor April 21, 2025 18:48
@fadi-george fadi-george merged commit 4eee2de into web-refractor Apr 21, 2025
@fadi-george fadi-george deleted the fg/login-exec-3 branch April 21, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants