Web SDK Refactor: Login Operation Executor Tests

[fadi-george]

Description

1 Line Summary

Continuation of the Web SDK Refactor project.

Details

• add tests for Login Operation Executor
• changed from Object.assign to variable assignment for subscriptions variable since delete subscription would need to remove properties and Object.assign will fail to do that
• for create subscription operation, made it more like the Android SDK implementation with passing just enabled, notifications_types (status), type, token (address)
• for update subscription operation, made it pass along notification_types & token
• added BaseFullSubscriptionOperation which has more subscription properties used for CreateSubscriptionOperation and UpdateSubscriptionOperation

Systems Affected

• WebSDK
• Backend
• Dashboard

Validation

Tests

Info

Checklist

• All the automated tests pass or I explained why that is not possible
• I have personally tested this on my machine or explained why that is not possible
• I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

• Don't use default export
• New interfaces are in model files

Functions:

• Don't use default export
• All function signatures have return types
• Helpers should not access any data but rather be given the data to operate on.

Typescript:

• No Typescript warnings
• Avoid silencing null/undefined warnings with the exclamation point

Other:

• Iteration: refrain from using elem of array syntax. Prefer forEach or use map
• Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

• I have included screenshots/recordings of the intended results or explained why they are not needed

---

Related Tickets

---

---

This change is 

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1210104364037057

[sherwinski]

I'm not sure what adding this line accomplishes from a user's perspective. From how I'm reading it, you can either call the constructor with all parameters, no parameters, or some combination of any of them. Is that not the same as all parameters being optional?

[fadi-george]

Its useful in the case you try to do something like this

new TransferSubscriptionOperation(APP_ID)

where now Typescript will complain that youre missing parameters.

[sherwinski]

So it's more like: include all parameters or include none?

[fadi-george]

Yes