chore: [SDK-4534] harden release workflow input handling#1462
Merged
Conversation
fadi-george
force-pushed
the
fadi/sdk-4534
branch
from
c1ed02e to
d76226b
Compare
fadi-george
changed the title
fadi-george
force-pushed
the
fadi/sdk-4534
branch
from
d76226b to
b5ff2c7
Compare
sherwinski
approved these changes
May 13, 2026
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Route step outputs through env: instead of inline interpolation in run: and actions/github-script script: bodies, and add a least-privilege top-level permissions: block. Co-authored-by: Cursor <cursoragent@cursor.com>
fadi-george
force-pushed
the
fadi/sdk-4534
branch
from
b5ff2c7 to
7c5e483
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Harden
create-release-pr.ymlby routing step outputs throughenv:and adding a least-privilegepermissions:block.Details
Internal hardening pass on the release workflow. See SDK-4534 for context.
Changes
permissions:block scoped tocontents: write+pull-requests: write.${{ steps.*.outputs.* }}interpolation insiderun:andactions/github-scriptscript:bodies with per-stepenv:mappings, referenced as$VAR(bash) orprocess.env.VAR(JS).<< 'EOF'and added a comment so the quoting is preserved.Systems Affected
Validation
Tests
Info
No automated coverage for workflow files. Verified by re-grep: every remaining
${{ steps.*.outputs.* }}reference now lives in anenv:key or inside the quoted heredoc. Bash logic inCalculate new versionand JS inGenerate release notesare functionally unchanged.Checklist
Screenshots
Info
N/A, workflow change.
Checklist
Related Tickets