Skip to content

ci: drop missing .nvmrc reference from CD and release workflows#1466

Merged
sherwinski merged 1 commit into
mainfrom
fix/missing-nvmrc-in-workflows
May 19, 2026
Merged

ci: drop missing .nvmrc reference from CD and release workflows#1466
sherwinski merged 1 commit into
mainfrom
fix/missing-nvmrc-in-workflows

Conversation

@sherwinski
Copy link
Copy Markdown
Contributor

One Line Summary

Remove stale node-version-file: '.nvmrc' from cd.yml and create-release-pr.yml so setup-vp stops failing.

Motivation

The Create Release PR workflow is currently broken at the Setup Vite+ step with:

Error: node-version-file not found: /home/runner/work/OneSignal-Website-SDK/OneSignal-Website-SDK/.nvmrc

.nvmrc was deleted in #1458 when the project switched to bun, and ci.yml was updated to drop the node-version-file input — but cd.yml and create-release-pr.yml still reference the missing file. This blocks both the release PR workflow and any future cd.yml runs.

Scope

  • Removes node-version-file: '.nvmrc' from .github/workflows/cd.yml (keeps cache: true).
  • Removes the same line (and the now-empty with: block) from .github/workflows/create-release-pr.yml.
  • No source code, dependency, or runtime behavior changes.

Testing

  • Manual: verified ci.yml (which already omits the input) is green on main, confirming setup-vp works without node-version-file.
  • Will validate end-to-end by re-running Create Release PR after merge.

Affected code

  • CI / build workflows
  • SDK runtime
  • Tests

Checklist

@sherwinski sherwinski requested a review from fadi-george May 19, 2026 21:18
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward CI fix that drops a reference to the deleted .nvmrc, mirroring the pattern already in ci.yml.

Extended reasoning...

Overview

This PR removes the stale node-version-file: '.nvmrc' input from the Setup Vite+ step in two workflows: .github/workflows/cd.yml and .github/workflows/create-release-pr.yml. The .nvmrc file was deleted in #1458 when the project migrated to bun, but these two workflows were missed. ci.yml was already updated and is passing without that input.

Security risks

None. This is a CI workflow configuration change that only removes a reference to a file that no longer exists. There is no impact on auth, secrets handling, permissions, or runtime SDK behavior.

Level of scrutiny

Low. This is a mechanical fix to unblock a broken workflow. I verified .nvmrc is absent from the repo and that ci.yml uses voidzero-dev/setup-vp@v1 without node-version-file successfully, so the same removal in cd.yml and create-release-pr.yml is a safe consistency change.

Other factors

The diff is two small hunks totaling four removed lines. The YAML remains syntactically valid (with: cache: true retained in cd.yml; with: block removed entirely in create-release-pr.yml since it would otherwise be empty). No bugs were flagged by the bug hunting system.

The .nvmrc file was removed in #1458 when the project switched to bun,
but cd.yml and create-release-pr.yml still reference it via
node-version-file, causing setup-vp to fail with
"node-version-file not found". Mirror the fix already applied in ci.yml.
@sherwinski sherwinski force-pushed the fix/missing-nvmrc-in-workflows branch from 8092d47 to 2f2f999 Compare May 19, 2026 21:23
@sherwinski sherwinski changed the title fix: drop missing .nvmrc reference from CD and release workflows ci: drop missing .nvmrc reference from CD and release workflows May 19, 2026
@sherwinski sherwinski merged commit 6f84e0c into main May 19, 2026
3 checks passed
@sherwinski sherwinski deleted the fix/missing-nvmrc-in-workflows branch May 19, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants