ci: drop missing .nvmrc reference from CD and release workflows#1466
Conversation
There was a problem hiding this comment.
LGTM — straightforward CI fix that drops a reference to the deleted .nvmrc, mirroring the pattern already in ci.yml.
Extended reasoning...
Overview
This PR removes the stale node-version-file: '.nvmrc' input from the Setup Vite+ step in two workflows: .github/workflows/cd.yml and .github/workflows/create-release-pr.yml. The .nvmrc file was deleted in #1458 when the project migrated to bun, but these two workflows were missed. ci.yml was already updated and is passing without that input.
Security risks
None. This is a CI workflow configuration change that only removes a reference to a file that no longer exists. There is no impact on auth, secrets handling, permissions, or runtime SDK behavior.
Level of scrutiny
Low. This is a mechanical fix to unblock a broken workflow. I verified .nvmrc is absent from the repo and that ci.yml uses voidzero-dev/setup-vp@v1 without node-version-file successfully, so the same removal in cd.yml and create-release-pr.yml is a safe consistency change.
Other factors
The diff is two small hunks totaling four removed lines. The YAML remains syntactically valid (with: cache: true retained in cd.yml; with: block removed entirely in create-release-pr.yml since it would otherwise be empty). No bugs were flagged by the bug hunting system.
The .nvmrc file was removed in #1458 when the project switched to bun, but cd.yml and create-release-pr.yml still reference it via node-version-file, causing setup-vp to fail with "node-version-file not found". Mirror the fix already applied in ci.yml.
8092d47 to
2f2f999
Compare
One Line Summary
Remove stale
node-version-file: '.nvmrc'fromcd.ymlandcreate-release-pr.ymlsosetup-vpstops failing.Motivation
The
Create Release PRworkflow is currently broken at theSetup Vite+step with:.nvmrcwas deleted in #1458 when the project switched to bun, andci.ymlwas updated to drop thenode-version-fileinput — butcd.ymlandcreate-release-pr.ymlstill reference the missing file. This blocks both the release PR workflow and any futurecd.ymlruns.Scope
node-version-file: '.nvmrc'from.github/workflows/cd.yml(keepscache: true).with:block) from.github/workflows/create-release-pr.yml.Testing
ci.yml(which already omits the input) is green onmain, confirmingsetup-vpworks withoutnode-version-file.Create Release PRafter merge.Affected code
Checklist
ci.ymlvia chore: update vite-plus, switch to bun, drop deepmerge #1458.nvmrcreintroduced (project is on bun)