feat(workflow): 'needs setup' status dot on nodes#2606
Open
simlarsen wants to merge 1 commit into
Open
Conversation
…red field The canvas already shows a red badge when a step errored on its last run, but nothing indicated a step that simply isn't configured yet. On a graph with several steps it wasn't obvious which ones still need attention. This adds a small amber dot to a node's corner when a required argument is still empty (mutually exclusive with the existing error badge). Backed by a pure getNodeStatus(data) → "error" | "incomplete" | "ready" helper so the logic is unit-tested; the node face just renders the indicator. Tests: 5 getNodeStatus cases (error / incomplete / ready / ignores optional / no-args). 54 workflow tests pass; tsc + eslint clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small node-face polish completing the "self-documenting canvas" theme. Stacked on #2605.
What
The canvas already shows a red badge when a step errored on its last run, but nothing flagged a step that simply isn't configured yet. On a graph with several steps you couldn't tell at a glance which ones still need attention.
This adds a small amber "needs setup" dot to a node's corner when a required argument is still empty (mutually exclusive with the existing error badge).
Backed by a pure helper:
so the logic is unit-tested; the node face just renders the indicator.
Verification
getNodeStatus(5 tests): error / incomplete / ready / ignores optional args / no-args step.tsc✓,eslint✓.🤖 Generated with Claude Code