feat(workflow): filter-row editor for database Query args#2615
Open
simlarsen wants to merge 1 commit into
Open
feat(workflow): filter-row editor for database Query args#2615simlarsen wants to merge 1 commit into
simlarsen wants to merge 1 commit into
Conversation
Database Query arguments (Find / Delete records) were hand-written JSON.
This edits the common case — flat equality filters — as rows: a field, a
value, and an explicit type.
- Pure QueryFilterUtils keeps each value's JSON type via a per-row type
selector (Text / Number / True-False), so it serializes to exactly the query
object an author would hand-write (a number stays a number). The stored value
remains a JSON string, so the server parses it identically — byte-safe.
- QueryFilterInput renders the rows with an "Edit as JSON" escape, and starts
in JSON mode automatically when the query isn't a flat equality (operator
objects like {"createdAt":{"_type":"GreaterThan",…}}, arrays, invalid JSON) —
so existing advanced queries never regress.
- ArgumentsForm routes Query to it (removed from the JSON-editor set), footer
suppressed.
Tests: QueryFilterUtils (type inference, operator/array/invalid → JSON
fallback, type-faithful serialization incl. number/boolean/no-NaN, empty
handling, round-trip) + QueryFilterInput RTL (renders typed rows, numeric
serialization, add/remove, JSON-mode fallback). 107 workflow tests pass; tsc +
eslint clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns hand-written database queries into simple filter rows. Stacked on #2614.
What
Database Query arguments (Find / Delete records) were hand-written JSON. This edits the common case — flat equality filters — as rows: a field, a value, and an explicit type.
QueryFilterUtilskeeps each value's JSON type via a per-row type selector (Text / Number / True-False), so it serializes to exactly the query object an author would hand-write — a number stays a number, a boolean stays a boolean. The stored value remains a JSON string, so the server parses it identically. Byte-safe.QueryFilterInputrenders the rows with an "Edit as JSON" escape, and starts in JSON mode automatically when the query isn't a flat equality — operator objects like{"createdAt":{"_type":"GreaterThan",…}}, arrays, or invalid JSON — so existing advanced queries never regress.ArgumentsFormroutesQueryto it (removed from the JSON-editor set); footer suppressed.Verification
QueryFilterUtils.test.ts: type inference on parse; operator/array/invalid →null(JSON fallback); type-faithful serialization (number stays number, boolean stays boolean, never writes NaN); empty-field drop; empty →""; round-trip.QueryFilterInput.test.tsx(RTL): renders typed rows; a number-typed row serializes to a numeric value; add/remove; JSON-mode fallback for operator queries.tsc✓,eslint✓.🤖 Generated with Claude Code