test(Common): add tests for Types/AI/CodeFixTaskTypeHelper#2681
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds unit tests for
CodeFixTaskTypeHelperinCommon/Types/AI/CodeFixTaskType.ts, which previously had no test coverage. These values are a wire contract (returned astaskTypeby/ai-agent-task/get-pending-task) and the helper drives which recipes are user-triggerable, which context record a queued run must carry, and how legacynullcolumns are normalized — all worth pinning down.Covered:
getUserTriggerableTaskTypes/isUserTriggerable— onlyFixExceptionandWriteRegressionTestare triggerable from the exception page;ImproveInstrumentation,FixPerformanceandFixFromIncidentare not (they have their own triggers).getContextKind— the full mapping (TelemetryException,IncidentOrAlertSubject,TaskContext), plus a check that every task type resolves to a known context kind, so a newly added recipe can't silently fall through.requiresTelemetryException— the per-type expectations, that it stays in sync withgetContextKind, and the invariant that every user-triggerable recipe is exception-based.isValidTaskType— accepts every enum value; rejects empty, unknown, and wrong-cased strings.fromDatabaseValue— normalizes legacynull/undefined(and unrecognized values) toFixException, and round-trips every valid task type including its raw wire string.Why
Improves test coverage for the
Common/Typesutilities (part of the broader test-coverage effort). The invariant tests guard the wire contract as new recipes get added.Testing
All 27 tests pass. The file is Prettier-clean.