fix(chat): allow null score in citation types, align with API and SDK#89
Open
EricNGOntos wants to merge 12 commits into
Open
fix(chat): allow null score in citation types, align with API and SDK#89EricNGOntos wants to merge 12 commits into
EricNGOntos wants to merge 12 commits into
Conversation
Release 2026-05-12
Release: Demo Mode, Dashboard UI Sync & Effect Refactor
Hotfix remove reconcile endpoint auth
Optimize chat prompts & Cache
Add tree view of chunks
…ed prompt generation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns Notebook citation types with the updated API contract where
scorecan benullfor agentic navigation-only results.Background
The agentic retrieval route now returns
nullforscoreon chunks found only through KG navigation (no BM25 discovery score available). The Node SDK has been updated (RetrievalResult.score: number | null). The Notebook's internal types and view layer need to match.Changes
src/domains/chat/types.tssrc/domains/chat/view.ts0is a valid real score;nullcorrectly signals 'no score available'.Testing