Complete #29
Open
Complete #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en deleting comments
octovinh
reviewed
Aug 27, 2019
There was a problem hiding this comment.
Hey Jared, can you add a .gitignore file to your PR? And then add the node_modules folder?
https://gist.github.com/lmcneel/45594e550a3403d589bdcaad38138a83
All the new files has made it difficult to review the PR.
Thanks!
codetest/dist/styles.css
Outdated
|
|
||
|
|
||
|
|
||
| background: -moz-linear-gradient(top, rgba(114,215,255,1) 0%, rgba(19,155,212,1) 100%); |
There was a problem hiding this comment.
You shouldn't have to use vendor prefixes for gradients:
https://caniuse.com/#search=gradient
http://shouldiprefix.com/#gradients
codetest/dist/styles.css
Outdated
| text-decoration: none; | ||
| } | ||
|
|
||
| .button.button-primary { |
There was a problem hiding this comment.
Nice use of semantic class names with button-primary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enjoyed this little project, it was nice to get back in to web dev a bit!
I wanted to use as few libraries as possible for this. I also wanted to use webcomponents because it's a new tech for me.
On Day 1, I just wanted to get the HTML and CSS in place to match the spec, along with some basic javascript functionality. At the end of the day I was able to make posts and comments.
On Day 2, I cleaned up a lot of my initial code, and broke more pieces out in to webcomponents.
I made the page a webcomponent, defined a posts controller, and wrote a datastore. At the end of Day 2 I felt I had most features in place.
On Day 3, I decided to include webpack, and set up dependencies between my webcomponents.
I also included a delete feature.
On Day 4, I cleaned up a bit. I wrapped my init JS into it's own class. I set max and min lengths with proper error messages. I handled over flows properly, and patched CSS to closer match the given design spec. I also added a simple sorting feature.