fix: cookie fetch missing function #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospfranco
reviewed
Apr 23, 2025
|
Will do tomorrow, I created a linear |
|
Ah, this function needs to be sync to return the data... let me take a look |
|
Ok, yeah, there is no way to make this function sync so it can return data to the Lua side without emitting an event. Ideally though, we would add an observer into the Cookie store used by the webview and just keep a map of the cookies ourselves. Here is the reference for adding an observer: https://developer.apple.com/documentation/webkit/wkhttpcookiestore/add(_:)?language=objc Going to merge this for now, with the caveat that it's a slow function that blocks the UI when called. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookie fetch function was missing while its signature was present in the interface, making the app crash.