Add rendering for auxiliary objects #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull request overview
This PR implements rendering support for Type 2 Auxiliary objects (AuxiliaryFunctionType2, AuxiliaryInputType2, and AuxiliaryControlDesignatorType2) in the ISOBUS VT object pool viewer. The implementation adds visual rendering for these object types and updates their documentation status from "not implemented" to "in progress/partial".
Key changes:
- Added rendering implementations for three auxiliary object types with background color support and child object rendering
- Removed the selectability constraint from WorkingSet rendering to enable rendering in auxiliary control designator contexts
- Updated Key object sizing to use
egui::Vec2::INFINITYin preparation for dynamic softkey area sizing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/object_rendering.rs | Implements rendering for AuxiliaryFunctionType2, AuxiliaryInputType2, and AuxiliaryControlDesignatorType2 objects; removes early return in WorkingSet::render; updates Key object sizing |
| README.md | Updates status indicators for Type 2 Auxiliary objects from white (not implemented) to yellow (partial/in progress) circles |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements rendering support for "Type 2" Auxiliary objects in the UI and updates their status in the documentation. The most significant changes are the addition of rendering logic for
AuxiliaryFunctionType2,AuxiliaryInputType2, andAuxiliaryControlDesignatorType2objects, as well as improvements to how object references are rendered in the UI.Rendering support for Type 2 Auxiliary objects
AuxiliaryFunctionType2andAuxiliaryInputType2objects, including drawing their background color and rendering their child object references. (src/object_rendering.rs)AuxiliaryControlDesignatorType2, handling all pointer types according to the VT specification, with placeholders for cases where runtime assignment info is not available. (src/object_rendering.rs)UI rendering improvements
Keyobjects to useegui::Vec2::INFINITYfor sizing, preparing for dynamic softkey area sizing. (src/object_rendering.rs)Documentation updates
README.mdfrom "not implemented" (white circle) to "in progress/partial" (yellow circle), reflecting the new rendering support. (README.md)Code cleanup
WorkingSet::renderthat previously prevented rendering if the object was not selectable, allowing for more flexible rendering logic. (src/object_rendering.rs)