Skip to content

Add support for Screen Capture command #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martonmiklos
Copy link
Contributor

@martonmiklos martonmiklos commented May 31, 2025

Added capability to make screen captures with the Screen capture command.
By default the screenshots are shared to the local settings directory/screen captures folder.
Command line option is also added to customize the folder path. (For automated testing for e.g.)

@martonmiklos martonmiklos force-pushed the add_support_for_screen_capture branch 2 times, most recently from 801b082 to 43b3e1a Compare May 31, 2025 18:41
@martonmiklos martonmiklos marked this pull request as draft May 31, 2025 18:44
@martonmiklos martonmiklos marked this pull request as ready for review June 1, 2025 10:25
@martonmiklos martonmiklos requested a review from ad3154 June 1, 2025 10:25
@martonmiklos martonmiklos force-pushed the add_support_for_screen_capture branch from 4ff0a0d to 22ec762 Compare June 1, 2025 10:29

#include <chrono>
#include <filesystem>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep it as cross platform as possible, it might be more beneficial to ditch filesystem and use JUCE's file handling to abstract things? Then we can keep our Cpp17 and be more confident perhaps that things would transfer well to mobile platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants