Skip to content

Refine pyOCD path setting for terminals #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Refine pyOCD path setting for terminals #152

merged 1 commit into from
Apr 9, 2025

Conversation

@jreineckearm
Copy link
Collaborator

@jreineckearm jreineckearm commented Apr 9, 2025 •
edited
Loading

Fixes

Changes

  • Uses prepend instead of replace env var collection mutator.
  • Only updates mutator if path not already set from previous session (cleans up mutators from previous approach).
    • This avoids the terminal to require a refresh on each workspace open.

Screenshots

Checklist

@jreineckearm
* prepend pyOCD path instead of replace entire variable
97bd958 
* check if old collection mutator type and if path already included

Signed-off-by: Jens Reinecke <[email protected]>
omarArm
omarArm approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@omarArm omarArm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it worked on my machine

@omarArm omarArm marked this pull request as ready for review April 9, 2025 12:45
@jreineckearm
Copy link
Collaborator Author

jreineckearm commented Apr 9, 2025

Thanks for testing! Waiting for original reporter to confirm this fixes problems showing quite consistently on his machine.

@jreineckearm
Copy link
Collaborator Author

jreineckearm commented Apr 9, 2025

Also got confirmation from other reporters issues are gone.
Fixes #153

@jreineckearm jreineckearm merged commit 9f31dd7 into main Apr 9, 2025
8 checks passed
@jreineckearm jreineckearm deleted the fix-variable-collections branch April 9, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omarArm omarArm omarArm approved these changes

@thorstendb-ARM thorstendb-ARM Awaiting requested review from thorstendb-ARM

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jreineckearm @omarArm