-
Notifications
You must be signed in to change notification settings - Fork 8
Markdown linter and link checker jobs #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
KeilChris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you wait with this PR until #215 is merged, please? I have changed the documentation content and this would end up in a blocked merge.
Make sense. Let's wait for your PR to merge, and then I will rework the touched files. |
|
Sorry, this needs to resolve conflicts coming with merge of #215 |
Merged your changes and applied the formatting rules on them. Please review |
Resolved |
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes and taking care of the initial conversion!
I'd lie if I'd say I understand all the config files yet. But I trust your knowledge here. :-)
Good to merge as far as I am concerned. But we may want to wait for @KeilChris to lift his change request.
KeilChris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must preserve the four spaces before sub-bulletpoints, otherwise the documentation build will create unexpected results.
KeilChris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! CI seems happy now
KeilChris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
The goal is to ensure that all changes to Markdown files follow consistent formatting standards and that any URLs included are valid and reachable. If any issues are detected, the workflow will fail and provide detailed output, highlighting the exact lines with errors along with clear error messages.