Integrate PyOCD distribution #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonatanAntoni
force-pushed
the
pyocd
branch
7 times, most recently
from
fd80166 to
393569f
Compare
Member
Author
Collaborator
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
Nice work! Some comments, the one that mainly needs attention is the user-agent setting for tool download for this OSS repo.
JonatanAntoni
force-pushed
the
pyocd
branch
2 times, most recently
from
448f6c3 to
f3429fc
Compare
added 8 commits
February 21, 2025 14:03
- Apache 2.0 copyright - Address review comments - Use yarn cache for tool downloads - Check tool sha256 if available
jreineckearm
approved these changes
Feb 21, 2025
Collaborator
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
Perfect! Thanks a lot for the quick work on this!
Works nicely now, also on my local Windows machine. Good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Changes
Screenshots
Checklist