-
Notifications
You must be signed in to change notification settings - Fork 8
Fix pyocd launch #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix pyocd launch #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
omarArm
requested changes
Feb 21, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the best course is to halt the device using monitor halt and then load. Obviously if there was no pre-existing image on the device already, then no need to halt
This reverts commit e2f2503.
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
omarArm
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
N/A
Changes
--targetand--pack. This will be obsolete with the first pyOCD dev drops that use--cbuild-run.--cbuild-runCLI arg if debug launch config item provided. NOTE: RemovecbuildRunFilesetting if using an older pyOCD version. Otherwise launching it will fail.gdbserverarg for pyOCD. Must be first argument. Relevant if mixing user provided server args with auto-filled ones.Screenshots
Checklist