Skip to content

Conversation

@KeilChris
Copy link
Collaborator

Changes

  • Created a one page README.md file inspired by VS Code Debug docu
  • Removed mkdocs dependency

@jreineckearm
Copy link
Collaborator

@KeilChris , is mkdocs going away completely, i.e. no HTML docs? There is ongoing infrastructure work which can be stopped if so.

@KeilChris
Copy link
Collaborator Author

@KeilChris , is mkdocs going away completely, i.e. no HTML docs? There is ongoing infrastructure work which can be stopped if so.

Yes, that would be the idea. Reinhard doesn't think that a big docu is necessary here (and I tend to agree).

ReinhardKeil
ReinhardKeil previously approved these changes May 28, 2025
Copy link
Collaborator

@ReinhardKeil ReinhardKeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KeilChris KeilChris dismissed ReinhardKeil’s stale review May 28, 2025 10:17

The merge-base changed after approval.

@qltysh
Copy link

qltysh bot commented May 28, 2025

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will not change total coverage.

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@soumeh01 soumeh01 requested a review from ReinhardKeil May 28, 2025 12:48
Copy link
Collaborator

@ReinhardKeil ReinhardKeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreineckearm jreineckearm merged commit 03774e1 into main May 28, 2025
14 checks passed
@jreineckearm jreineckearm deleted the update_readme branch May 28, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants